Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for primary zones for generic location format in TimeZoneFormat #987

Closed
nordzilla opened this issue Aug 25, 2021 · 0 comments · Fixed by #5657
Closed

Account for primary zones for generic location format in TimeZoneFormat #987

nordzilla opened this issue Aug 25, 2021 · 0 comments · Fixed by #5657
Labels
blocked A dependency must be resolved before this is actionable C-time-zone Component: Time Zones help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-core Type: Required functionality
Milestone
Priority Backlog ...

Comments

@nordzilla
Copy link
Member

nordzilla commented Aug 25, 2021 •
edited
Loading

When performing generic location format, we need to check if the current zone is the primary zone for its country and use the country name instead of the exemplar city if so.

Depends on:
@nordzilla nordzilla mentioned this issue Aug 25, 2021
Open
1 task
@nordzilla nordzilla added C-datetime Component: datetime, calendars, time zones help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-core Type: Required functionality blocked A dependency must be resolved before this is actionable labels Aug 25, 2021
@nordzilla nordzilla added this to the ICU4X 0.5 milestone Aug 26, 2021
@nordzilla nordzilla modified the milestones: ICU4X 0.5, ICU4X 1.0 Jan 20, 2022
@sffc sffc added C-time-zone Component: Time Zones and removed C-datetime Component: datetime, calendars, time zones labels Dec 22, 2022
This was referenced Oct 8, 2024
Merged
Merged
robertbastian pushed a commit that referenced this issue Oct 8, 2024
@sffc
Remove VVV time zone format (#5659)
af8dbac 
Unblocks #987
See #5658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked A dependency must be resolved before this is actionable C-time-zone Component: Time Zones help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Milestone
Priority Backlog ⟨P3⟩
Development

Successfully merging a pull request may close this issue.

Fix generic location format for single-tz countries robertbastian/icu4x
2 participants
@sffc @nordzilla