Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generic location format for single-tz countries #5657

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Fix generic location format for single-tz countries #5657

merged 11 commits into from
Oct 10, 2024

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Oct 8, 2024 •
edited
Loading

It's meant to say "Germany Time" instead of "Berlin time" : UTS 35

Fixes #987 #996

sffc
sffc reviewed Oct 8, 2024
View reviewed changes
components/datetime/src/format/neo.rs Outdated
e,
fields::Field {
symbol: FieldSymbol::TimeZone(fields::TimeZone::UpperV),
length: FieldLength::Wide,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought: we should probably plumb the NeoSkeletonLength through to here. (seems minor enough to make it an issue to be fixed later)

@sffc
Copy link
Member

sffc commented Oct 8, 2024

Note: there is an issue for this already, #987

I had been thinking for a while that the way to fix the issue would be to just change the strings in exemplar_cities via datagen, but I never posted it in the issue.

@robertbastian robertbastian requested a review from sffc October 8, 2024 11:30
@sffc
Copy link
Member

sffc commented Oct 8, 2024

Thought: After this lands, we should strip data from vvvv that is equivalent to the data in VVVV since the two fall back between each other. Maybe even do a similar optimization with zzzz.

@sffc sffc mentioned this pull request Oct 8, 2024
Merged
sffc
sffc reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send back when ready

@robertbastian robertbastian requested a review from sffc October 8, 2024 13:11
robertbastian
robertbastian commented Oct 8, 2024
View reviewed changes
provider/source/data/debug/time_zone/exemplar_cities@1/en-001.json
"uzskd": "Samarkand",
"uztas": "Tashkent",
"vavat": "Vatican",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny that the city is Vatican and the country is Vatican City.

@robertbastian robertbastian merged commit a824262 into unicode-org:main Oct 10, 2024
28 checks passed
@robertbastian robertbastian mentioned this pull request Oct 11, 2024
Merged
robertbastian added a commit that referenced this pull request Oct 11, 2024
@robertbastian
Restructure time zone data structs (#5671)
cc7b9eb 
* Exemplar cities should now be called locations (#5657)
* Region patterns can live in the locations struct
* Offset pattern can be split into signs and separator (#5638)
@robertbastian robertbastian deleted the primaryzone branch October 16, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@Manishearth Manishearth Awaiting requested review from Manishearth Manishearth is a code owner

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account for primary zones for generic location format in TimeZoneFormat
2 participants
@robertbastian @sffc