fix: Separate redis security group rules (#13)

* separate redis security group rules * format
wandb · Feb 14, 2022 · 71345d6 · 71345d6
1 parent 5d4fd97
commit 71345d6
Showing 1 changed file with 17 additions and 13 deletions.
diff --git a/modules/redis/main.tf b/modules/redis/main.tf
@@ -27,18 +27,22 @@ resource "aws_elasticache_replication_group" "default" {
 resource "aws_security_group" "redis" {
   name   = "${var.namespace}-elasticache-security-group"
   vpc_id = var.vpc_id
+}
+
+resource "aws_security_group_rule" "ingress" {
+  type              = "ingress"
+  protocol          = "tcp"
+  from_port         = "6379"
+  to_port           = "6379"
+  cidr_blocks       = var.vpc_subnets_cidr_blocks
+  security_group_id = aws_security_group.redis.id
+}
 
-  ingress {
-    protocol    = "tcp"
-    from_port   = "6379"
-    to_port     = "6379"
-    cidr_blocks = var.vpc_subnets_cidr_blocks
-  }
-
-  egress {
-    protocol    = "tcp"
-    from_port   = "6379"
-    to_port     = "6379"
-    cidr_blocks = var.vpc_subnets_cidr_blocks
-  }
+resource "aws_security_group_rule" "egress" {
+  type              = "egress"
+  protocol          = "tcp"
+  from_port         = "6379"
+  to_port           = "6379"
+  cidr_blocks       = var.vpc_subnets_cidr_blocks
+  security_group_id = aws_security_group.redis.id
 }