fix: Separate redis security group rules #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elainaRenee
requested review from
jsbroks,
zythosec and
vanpelt
as code owners
vanpelt
approved these changes
Feb 14, 2022
|
In the original, you are only using only inline rules? so it shouldn't cause a conflict? |
jsbroks
reviewed
Feb 14, 2022
| from_port = "6379" | ||
| to_port = "6379" | ||
| cidr_blocks = var.vpc_subnets_cidr_blocks | ||
| security_group_id = aws_security_group.redis.id |
|
I updated the description with some info I found in the docs which lead me to this change. This appears to have fixed the confusion I was observing in the plan. I was using the |
jsbroks
pushed a commit
that referenced
this pull request
Feb 14, 2022
### [1.0.4](v1.0.3...v1.0.4) (2022-02-14) ### Bug Fixes * Separate redis security group rules ([#13](#13)) ([71345d6](71345d6))
|
This PR is included in version 1.0.4 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using inline security group rules in the
aws_security_groupresource along with the standaloneaws_security_group_ruleresource causes conflicts when the terraform is applied and rules to be overwritten. This pr separates the rules out into their own resources.