-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: rework E2Es #956
base: main
Are you sure you want to change the base?
test: rework E2Es #956
Conversation
Targetting |
07754e5
to
1d0bade
Compare
8f7428b
to
64c0acc
Compare
64c0acc
to
5a730b3
Compare
@mato533 Just to let you know I thought I'd do the yarn hack removal in this PR, and rework the E2Es at the same time. Basically deal with all the tech debt before getting some traction on v9. Let me know what you think of this matrix approach to the E2Es, and if you have any improvements. I decided to ditch the JS variants of the E2Es for now in order to make the rework simpler, these variants were put in place for a specific bug that was masked by the use of |
@goosewobbler Basically, The matrix approach seems to be good idea. I've put together some points that I think need improvement. I hope it helps.
|
Incidentally, it is assumed that the dependency between sample-apps and the service will completely disappear from v9. (because wdio-electron-service will have no more preload/main scripts to import due to the IPC-Bridge replacement). This should allow e2e app builds to run in parallel with serivce builds, which may be able to improve things in some way when v9 is released. |
8cb54e8
to
d754d48
Compare
d754d48
to
5317779
Compare
1367271
to
677079d
Compare
a1b9bdd
to
b4e2544
Compare
4b23b5c
to
2fe5a77
Compare
2fe5a77
to
6fb958d
Compare
b095a2c
to
9983946
Compare
aa764e3
to
ad418e5
Compare
9ad49bb
to
6be9662
Compare
6be9662
to
fdbf00b
Compare
Reworking the E2Es so that they use a matrix-based approach and the packaged version of the service.
Closes #955
TODO:
test:all
)test:window
multiremote variant