-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdp): implementation of cdp-bridge
#961
base: feature/v9
Are you sure you want to change the base?
Conversation
@goosewobbler We will create another pull request with base as main to close #308, based on the base branch of this PR. |
cdp-bridge
cdp-bridge
@goosewobbler After that, I would like to discuss the possibility of releasing this change as part of v8 (minor update). |
I see - well, it doesn't NEED to be released before v9 as nothing in v8.x.y will use the new package. However I'm not against getting the new package published as part of 8.x.y if it will make the v9 dev easier in some way... |
@goosewobbler It will also be possible to test when ‘feature/v9’ is created and v9.next can be released. UpdateWe have completed to get rid of the code related for backward compatibility.(the commit belongs to #969) |
@mato533 I created |
@goosewobbler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new package (@wdio/cdp-bridge) that provides a lightweight interface for connecting to the Node debugger via the Chrome Developer Protocol (CDP). Key changes include:
- Adding package configuration to the monorepo (pnpm-workspace.yaml)
- Implementing the main library files for connecting to the debugger (dev-tool, bridge, types, constants)
- Adding unit and end-to-end tests as well as build configuration via Rollup and documentation in the README
Reviewed Changes
Copilot reviewed 12 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
pnpm-workspace.yaml | Added new package entry for cdp-bridge |
packages/@wdio_electron-cdp-bridge/vitest.config.ts | Setup of vitest configuration for the new package |
packages/@wdio_electron-cdp-bridge/test/dev-tool.spec.ts | Unit tests for DevTool functionality |
packages/@wdio_electron-cdp-bridge/test/bridge.spec.ts | Unit tests for CdpBridge covering connection, messaging, etc. |
packages/@wdio_electron-cdp-bridge/src/types.ts | Type definitions for debugger info and version data |
packages/@wdio_electron-cdp-bridge/src/index.ts | Entry point re-exporting public API components |
packages/@wdio_electron-cdp-bridge/src/dev-tool.ts | Implements debugger connection and request execution |
packages/@wdio_electron-cdp-bridge/src/constants.ts | Declaration of default settings and error messages |
packages/@wdio_electron-cdp-bridge/src/bridge.ts | Implements the bridge class for sending commands and handling events |
packages/@wdio_electron-cdp-bridge/rollup.config.ts | Build configuration for both ESM and CJS modules |
packages/@wdio_electron-cdp-bridge/e2e/node.spec.ts | End-to-end tests for cdp-bridge functionality |
packages/@wdio_electron-cdp-bridge/README.md | Documentation and usage examples for the new package |
Files not reviewed (6)
- packages/@wdio_electron-cdp-bridge/e2e/tsconfig.json: Language not supported
- packages/@wdio_electron-cdp-bridge/package.json: Language not supported
- packages/@wdio_electron-cdp-bridge/test/tsconfig.json: Language not supported
- packages/@wdio_electron-cdp-bridge/tsconfig.json: Language not supported
- pnpm-lock.yaml: Language not supported
- turbo.json: Language not supported
Comments suppressed due to low confidence (1)
packages/@wdio_electron-cdp-bridge/README.md:3
- [nitpick] Replace the non-standard hyphen 'ー' with a standard hyphen '-' in the package name URL.
<a href="https://www.npmjs.com/package/@wdio/cdpーbridge" alt="NPM Version">
Not sure what you mean here, you mean it has merge conflicts with main now? We can just recreate it before merge... EDIT: just recreated |
9c77975
to
519f967
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
8ada78b
to
dee72ff
Compare
Sorry....it's so hard to understand....
|
Got it, haha! We started off using v9 and then changed it. |
This new package (@wdio/cdp-bridge) will be used to connect the node debugger.
*) This PR uses the IPC-Bridge replacement development branch ‘ta/cdp/main’ as the Base Branch.