Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse move outside of window while dragging causes error #71

Closed
kaufmo opened this issue Jul 5, 2017 · 2 comments
Closed

Mouse move outside of window while dragging causes error #71

kaufmo opened this issue Jul 5, 2017 · 2 comments

Comments

@kaufmo
Copy link
Contributor

kaufmo commented Jul 5, 2017

Hello,
do you know the problem when you drag the handle and move the mouse outside of the window?

The error comes from the handleDrag function, because target changes to document dom element and there is no classList option. I think this will be solved when you check if target has the attribute classList?

Best regards,
Alex

@tomay
Copy link

tomay commented Aug 7, 2017

Is it this error you are referring to?

Uncaught TypeError: Cannot read property 'contains' of undefined
    at HTMLDocument.Slider._this.handleDrag (eval at <anonymous> (bundle.js:4), <anonymous>:111:27)

I get these even on the demo page:
https://whoisandy.github.io/react-rangeslider/

@kaufmo
Copy link
Contributor Author

kaufmo commented Aug 8, 2017

yes it's the same error

whoisandy added a commit that referenced this issue Sep 19, 2017
closes #50, #52
fixes #60, #71, #73, #79

BREAKING CHANGE:

`rangeslider__label-list` renamed to `rangeslider__labels` & `rangeslider__labels-item`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants