Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thow error when user drag mouse over scroll bar #79

Closed
bondsua opened this issue Aug 29, 2017 · 0 comments
Closed

thow error when user drag mouse over scroll bar #79

bondsua opened this issue Aug 29, 2017 · 0 comments

Comments

@bondsua
Copy link

bondsua commented Aug 29, 2017

react-rangeslider/src/Rangeslider.js

Line 135 in 27fc260

target.classList.contains('rangeslider__label') && target.dataset.value

Need add сheck if target instance of HTML element or remove if not need this.
Test case:

  • click on slider;
  • drag mouse over scroll bar;
    Event target got the #document and thow error
whoisandy added a commit that referenced this issue Sep 19, 2017
@whoisandy
feat(slider): support for click and drag, accessibility
177d433 
closes #50, #52
fixes #60, #71, #73, #79

BREAKING CHANGE:

`rangeslider__label-list` renamed to `rangeslider__labels` & `rangeslider__labels-item`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whoisandy @bondsua