Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.7 cannot save empty repeater #1290

Closed
AIC-BV opened this issue Jan 20, 2025 · 6 comments · Fixed by #1300
Closed

1.2.7 cannot save empty repeater #1290

AIC-BV opened this issue Jan 20, 2025 · 6 comments · Fixed by #1300
Assignees
Labels
accepted Issues that have been accepted by the maintainers for inclusion
Milestone

Comments

@AIC-BV
Copy link
Contributor

AIC-BV commented Jan 20, 2025

Winter CMS Build

dev-develop

PHP Version

8.1

Database engine

MySQL/MariaDB

Plugins installed

No response

Issue description

Since 1.2.7 it is no longer possible to save an empty repeater.
Removing all items and saving, will result in no changes at all.
Removing 10 items, leaving one and saving, will result in one item in the repeater. Removing the last item will not work.

Steps to replicate

  1. Create a repeater with content
  2. Save
  3. Remove the content
  4. Save
    => The content is still there

Workaround

Delete the data through phpmyadmin/sql workbench/...

@mjauvin mjauvin self-assigned this Jan 20, 2025
@mjauvin mjauvin added accepted Issues that have been accepted by the maintainers for inclusion needs pr Issues that are awaiting a PR to be submitted labels Jan 20, 2025
@mjauvin mjauvin added this to the 1.2.8 milestone Jan 20, 2025
@AIC-BV
Copy link
Contributor Author

AIC-BV commented Jan 21, 2025

I figured when downgrading backend module to 1.2.6 it works again: "winter/wn-backend-module": "1.2.6"
(and Tailwind UI to dev-main#42dabcdf7e0daaa2b0dddd5fd5117412e8577e1a because latest version depends on Vite which was added in backend-module 1.2.7)

@AIC-BV
Copy link
Contributor Author

AIC-BV commented Jan 24, 2025

I think it is because of this
wintercms/wn-backend-module@9cc2bd8

But reverting this also seems to break the repeater (all empty repeaters get an empty row)
@LukeTowers any idea?

@LukeTowers
Copy link
Member

@AIC-BV is this still an issue on the latest develop branch? @mjauvin any thoughts?

@mjauvin
Copy link
Member

mjauvin commented Jan 25, 2025

@AIC-BV is this still an issue on the latest develop branch? @mjauvin any thoughts?

Submitted a PR.

@LukeTowers
Copy link
Member

@AIC-BV can you test #1300 and let me know if that solves the issue?

@mjauvin mjauvin removed the needs pr Issues that are awaiting a PR to be submitted label Jan 25, 2025
@AIC-BV
Copy link
Contributor Author

AIC-BV commented Jan 28, 2025

@LukeTowers Solved! ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issues that have been accepted by the maintainers for inclusion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants