Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeater: Always send a value in the Form data #1300

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Repeater: Always send a value in the Form data #1300

merged 2 commits into from
Jan 28, 2025

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Jan 25, 2025

Fixes #1290

@mjauvin mjauvin added the maintenance PRs that fix bugs, are translation changes or make only minor changes label Jan 25, 2025
@mjauvin mjauvin added this to the 1.2.8 milestone Jan 25, 2025
@mjauvin mjauvin requested a review from LukeTowers January 25, 2025 05:27
@mjauvin mjauvin self-assigned this Jan 25, 2025
@LukeTowers LukeTowers changed the title Fix empty repeater save value Repeater: Always send a value in the Form data Jan 25, 2025
@LukeTowers LukeTowers mentioned this pull request Jan 25, 2025
Closed
@AIC-BV
Copy link
Contributor

AIC-BV commented Jan 27, 2025 •
edited
Loading

I'm getting undefined $field variable in _repeater.php

Oh, I have ofcourse the MLRepeater!
And only copying the Repeater.php formwidget does not seem to solve the problem

@mjauvin
Copy link
Member Author

mjauvin commented Jan 27, 2025

I'm getting undefined $field variable in _repeater.php

Oh, I have ofcourse the MLRepeater! And only copying the Repeater.php formwidget does not seem to solve the problem

Sorry, I screwed up... latest commit should fix it.

@AIC-BV
Copy link
Contributor

AIC-BV commented Jan 28, 2025

Fixed! Thanks

@LukeTowers LukeTowers merged commit 9f38dff into develop Jan 28, 2025
13 checks passed
@LukeTowers LukeTowers deleted the fix-empty-repeater branch January 28, 2025 16:15
@mjauvin mjauvin mentioned this pull request Feb 13, 2025
Merged
LukeTowers pushed a commit to wintercms/wn-blocks-plugin that referenced this pull request Feb 13, 2025
@mjauvin
Blocks: Always send a value in the Form data (#50)
d3e686a 
Replicates fix that was done for repeater formwidget (see wintercms/winter#1300)

This also prevents an infinite loop when calling renderBlocks() on empty blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeTowers LukeTowers Awaiting requested review from LukeTowers

Assignees

@mjauvin mjauvin

Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Milestone
1.2.8
Development

Successfully merging this pull request may close these issues.

1.2.7 cannot save empty repeater
3 participants
@mjauvin @AIC-BV @LukeTowers