Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Always send a value in the Form data #50

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Feb 13, 2025

Replicate fix that was done for repeater formwidget.

This also prevents an infinite loop when calling renderBlocks() on empty blocks.

ref. wintercms/winter#1300

@mjauvin mjauvin requested a review from LukeTowers February 13, 2025 04:44
@mjauvin mjauvin self-assigned this Feb 13, 2025
@LukeTowers LukeTowers merged commit d3e686a into main Feb 13, 2025
6 checks passed
@LukeTowers LukeTowers deleted the fix-empty-blocks branch February 13, 2025 04:48
@mjauvin
Copy link
Member Author

mjauvin commented Feb 13, 2025

@LukeTowers you were too quick, might have found an issue with this...

@mjauvin
Copy link
Member Author

mjauvin commented Feb 13, 2025

Ahh, never mind, was caused by a left-over from the PR that used Fluent in the block config... all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants