Use v0.60.0 patch from jtreanor/react-native #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtreanor
force-pushed
the
rn-0.60.0-patch
branch
3 times, most recently
from
ec586eb to
d1d4b19
Compare
jtreanor
changed the title
1 task
jtreanor
commented
Jul 3, 2019
| s.dependency 'React/RCTActionSheet', react_native_version | ||
| s.dependency 'React/DevSupport', react_native_version | ||
| s.dependency 'React-Core', react_native_version | ||
| s.dependency 'React-RCTImage', react_native_version |
There was a problem hiding this comment.
Reducing these to only what we need means that the build will be leaner and hopefully faster. Transitive dependencies (such as yoga) will still be resolved.
jtreanor
commented
Jul 3, 2019
| cd "node_modules/react-native" | ||
|
|
||
| RN_PODSPECS=$(find * -type f -name "*.podspec" -not -path "third-party-podspecs/*" -print) |
There was a problem hiding this comment.
Now using find to generate all the podspecs in react-native. This means we have a lot more podspecs in the repo (hence the big diff).
etoledom
approved these changes
Jul 5, 2019
There was a problem hiding this comment.
- Android demo app
- iOS demo app
- WPiOS (from Gutenberg: Compatibility with React Native 0.60.0 WordPress-iOS#12056)
- Running internal JS Bundle ✅
- Running metro from this branch ✅
- WPAndroid (Tested by @daniloercoli - Thank you! 🙏 )
Everything seems to work as expected.
Thank you so much @jtreanor. This has been a big one!
|
cc @marecar3 - With this we are fixing the integration of RN 0.60 on WPiOS. This should unblock the merge of |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates gutenberg-mobile to use a version of RN
v0.60.0which is patched with my changes from facebook/react-native#25393. I have just cherry-picked my changes onto the releasev0.60.0version so there are no other unexpected changes.I have updated the podspecs of our dependencies:
The alternative to the above changes would be to maintain our own copies of the podspecs in
third-party-podspecs. You can exclude the podspecs from the diff by going here.To do: Patch the podspec ofThis is now done in a fork here: https://github.com/wordpress-mobile/react-native-safe-area/tree/rn-0.60.0-patchreact-native-safe-area(its manually updated in this PR for now).To test:
Update release notes:
RELEASE-NOTES.txt.