Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Gutenberg.podspec depend on React pod to avoid Native Module errors #1198

Merged
merged 2 commits into from
Jul 5, 2019

Conversation

jtreanor
Copy link
Contributor

@jtreanor jtreanor commented Jul 5, 2019

In #1184 I reduced the RN pods that Gutenberg.podspec depends on. After seeing a few Native module cannot be null errors I think its safer to depend on all of React. Otherwise there is a risk of shipping with a crash we don't realise.

It also allows us to revert the podspec changes to all of our third party libraries.

I have also updated the WPiOS PR here: wordpress-mobile/WordPress-iOS#12056

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jtreanor jtreanor requested a review from etoledom July 5, 2019 14:19
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call @jtreanor !

This is probably the safest way to go 👍

@jtreanor jtreanor merged commit 7023a2d into issue/android_x_migration Jul 5, 2019
@jtreanor jtreanor deleted the update-podspec branch July 5, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants