Release v1.10.0 #1246
Release v1.10.0 #1246
Conversation
…rg-mobile into add/tests-image-block
…rg-mobile into add/tests-image-block
…rg-mobile into add/tests-heading-block
…rg-mobile into add/tests-add-block-insertion
Address fix for issue where inserting a block from the post title would not replace an empty paragraph block if that block was the first block in the post. Instead it would add a second empty paragraph block at the beginning of the post.
…ial-empty-paragraph-block-from-title When inserting block from title replace block if appropriate
…on-config Update vscode extension config to prevent VSCode to show a warning on project opening
Node 9.x seems no longer relevant since we are now directing devs to use `nvm install --latest-npm` (currently v.12.6.0)
…re-default-tagname Fix loss of center alignment in image captions on Android
RELEASE-NOTES.txt
Outdated
| ------ | ||
| * Adding a block from the post title now shows the add block here indicator. | ||
| * Deselect post title any time a block is added | ||
| * Fix merging of empty paragraph blocks when added from a post's title |
There was a problem hiding this comment.
@Tug In light of your comment (WordPress/gutenberg#16677 (comment)) that we may not want this change
and since we're likely going to lose it with your imminent PR merge, we might want to pull this line out of the release notes. Alternatively, I could revert the entire change from #1227. What do you think?
There was a problem hiding this comment.
If you think we can easily revert it, let's do this. Otherwise keeping it shouldn't impact the user experience too much I think
RELEASE-NOTES.txt
Outdated
| * Adding a block from the post title now shows the add block here indicator. | ||
| * Deselect post title any time a block is added | ||
| * Fix merging of empty paragraph blocks when added from a post's title | ||
| * Fix loss of center alignment in image captions |
There was a problem hiding this comment.
Looking back at this now, seems like I perhaps should have called this out as being an Android-specific issue. I'm happy to add that change if you agree.
There was a problem hiding this comment.
Ok, I'll update and remove it from https://github.com/wordpress-mobile/WordPress-iOS/pull/12210/files#diff-a3d054590c32de57d87be233927e755dR9
| @@ -1,3 +1,10 @@ | |||
| 1.10.0 | |||
| ------ | |||
| * Adding a block from the post title now shows the add block here indicator. | |||
There was a problem hiding this comment.
There is one final edge case for this (adding from the post title on a new post when there is just the placeholder text and no paragraph block yet) is still not fixed. Should we pull this from the release notes until that is fixed?
There was a problem hiding this comment.
I think this is fine as it's included in this release
There was a problem hiding this comment.
Aww, but that screws up my plan of changing all the release notes. 😉
This was previously removed, but somehow snuck back in. Previous discussion: #1246 (comment) Previous revert commit: d6a551a
This merges
release/1.10.0tomasterfor the next releases of the WPAndroid/WPiOS apps.Gutenberg branch: WordPress/gutenberg#16775
WPAndroid PR: wordpress-mobile/WordPress-Android#10286
WPiOS PR: wordpress-mobile/WordPress-iOS#12210