Release v1.10.0

.circleci/config.yml

@@ -6,13 +6,13 @@ commands:
       - restore_cache:
           name: Restore Yarn Cache
           keys:
-            - yarn-i18n-v1-{{ .Environment.CIRCLE_JOB }}-{{ checksum "yarn.lock" }}
+            - yarn-i18n-v3-{{ .Environment.CIRCLE_JOB }}-{{ checksum "yarn.lock" }}
       - run:
           name: Yarn Install
           command: yarn install --frozen-lockfile --prefer-offline
       - save_cache:
           name: Save Yarn Cache
-          key: yarn-i18n-v1-{{ .Environment.CIRCLE_JOB }}-{{ checksum "yarn.lock" }}
+          key: yarn-i18n-v3-{{ .Environment.CIRCLE_JOB }}-{{ checksum "yarn.lock" }}
           paths:
             - node_modules
             - i18n-cache/data
@@ -61,7 +61,7 @@ jobs:
           path: ./reports/test-results
   android-device-checks:
     docker:
-    - image: circleci/android:api-28-node8-alpha
+    - image: circleci/android:api-29-node
     steps:
       - checkout
       - run:
@@ -80,7 +80,8 @@ jobs:
       - run:
           name: Upload apk to sauce labs
           command: |
-            curl -u "$SAUCE_USERNAME:$SAUCE_ACCESS_KEY" -X POST -H "Content-Type: application/octet-stream" https://saucelabs.com/rest/v1/storage/automattic/Gutenberg.apk?overwrite=true --data-binary @./android/app/build/outputs/apk/debug/app-debug.apk
+            source bin/sauce-pre-upload.sh
+            curl -u "$SAUCE_USERNAME:$SAUCE_ACCESS_KEY" -X POST -H "Content-Type: application/octet-stream" https://saucelabs.com/rest/v1/storage/automattic/Gutenberg-$SAUCE_FILENAME.apk?overwrite=true --data-binary @./android/app/build/outputs/apk/debug/app-debug.apk
       - run:
           name: Run Device Tests
           command: yarn device-tests
@@ -111,21 +112,21 @@ jobs:
     - restore_cache:
         name: Restore Dependencies Cache
         keys:
-        - dependencies-{{ checksum "react-native-aztec/ios/Cartfile.resolved" }}-{{
+        - dependencies-v2-{{ checksum "react-native-aztec/ios/Cartfile.resolved" }}-{{
           checksum "yarn.lock" }}
-        - dependencies-{{ checksum "react-native-aztec/ios/Cartfile.resolved" }}
-        - dependencies-
+        - dependencies-v2-{{ checksum "react-native-aztec/ios/Cartfile.resolved" }}
+        - dependencies-v2-
     - run:
         name: Yarn preios (if needed)
         command: test -e ios/build/gutenberg/Build/Products/Release-iphonesimulator/gutenberg.app || yarn preios
     - save_cache:
         name: Save Dependencies Cache
-        key: dependencies-{{ checksum "react-native-aztec/ios/Cartfile.resolved" }}-{{
+        key: dependencies-v2-{{ checksum "react-native-aztec/ios/Cartfile.resolved" }}-{{
           checksum "yarn.lock" }}
         paths:
         - react-native-aztec/ios/Carthage
         - ~/.rncache
-    - run: 
+    - run:
         name: Build (if needed)
         command: test -e ios/build/gutenberg/Build/Products/Release-iphonesimulator/gutenberg.app || yarn react-native run-ios --configuration Release --no-packager
     - run:
@@ -137,7 +138,8 @@ jobs:
     - run:
         name: Upload .app to sauce labs
         command: |
-          curl -u "$SAUCE_USERNAME:$SAUCE_ACCESS_KEY" -X POST -H "Content-Type: application/octet-stream" https://saucelabs.com/rest/v1/storage/automattic/Gutenberg.app.zip?overwrite=true --data-binary @./ios/Gutenberg.app.zip
+          source bin/sauce-pre-upload.sh
+          curl -u "$SAUCE_USERNAME:$SAUCE_ACCESS_KEY" -X POST -H "Content-Type: application/octet-stream" https://saucelabs.com/rest/v1/storage/automattic/Gutenberg-$SAUCE_FILENAME.app.zip?overwrite=true --data-binary @./ios/Gutenberg.app.zip
     - run:
         name: Run Device Tests
         command: |

.vscode/extensions.json

@@ -1,6 +1,6 @@
 {
     "recommendations": [
         "gcazaciuc.vscode-flow-ide",
-        "vsmobile.vscode-react-native"
+        "msjsdiag.vscode-react-native"
     ]
 }

README.md

@@ -41,12 +41,6 @@ nvm install --latest-npm
 yarn install
 ```
 
-Note: using node v9.x currently produces the following error:
-```
-error sane@3.1.0: The engine "node" is incompatible with this module. Expected version "6.* || 8.* || >= 10.*".
-```
-To be revisited, as we don't need to impose a limit in version per se.
-
 ## Run
 
 ```
@@ -141,7 +135,7 @@ and for android run,
 
 Note, you might experience problems that seem to be related to the tests starting the Appium server, for example errors that say `Connection Refused`, `Connection Reset` or `The requested environment is not available`. Sorry about that this is still a WIP, you can manually start the Appium server via [appium desktop](https://github.com/appium/appium-desktop) or the cli, then change the port number in the tests while optionally commenting out related code in the `beforeAll` and `afterAll` block. 
 
-For a more detailed outline of the UI tests and how to get started writing one please visit the [Project Wiki](https://github.com/wordpress-mobile/gutenberg-mobile/wiki/Getting-started-with-UI-tests)
+For a more detailed outline of the UI tests and how to get started writing one please visit the [UI Test documentation](https://github.com/wordpress-mobile/gutenberg-mobile/blob/develop/__device-tests__/README.md) and our [contributing guide](https://github.com/wordpress-mobile/gutenberg-mobile/blob/develop/__device-tests__/CONTRIBUTING.md).
 
 ## Static analysis and code style
 

RELEASE-NOTES.txt

@@ -1,3 +1,9 @@
+1.10.0
+------
+* Adding a block from the post title now shows the add block here indicator.
+* Deselect post title any time a block is added
+* Fix loss of center alignment in image captions on Android
+
 1.9.0
 ------
 * Enable video block on Android platform

__device-tests__/CONTRIBUTING.md

@@ -0,0 +1,44 @@
+Writing a UI test? Great! 😬 This guide is here to help fill in some of the blanks of how the tests are written now and how you can add a new one. 
+
+You can find our on-device UI tests in the `__device-tests__` folder and that's where all of the code for that really lives.  
+The test suite follows a sort of [Page Object Pattern](https://webdriver.io/docs/pageobjects.html), the `__device-tests__/pages/editor-page.js` manages all interactions with the pages and the `__device-tests__/gutenberg-editor.test.js` actually uses the functions made available via the Page Object `EditorPage` to drive the test cases. At the time of writing this, all the tests live there but as the suite gets large it might be better to manage different classes of tests in different files. 
+
+So what does the process for writing a test look like? Here are some steps that I hope can help make this easier,
+
+### First, define the scenario
+
+- What are the actions that need to take place here? Walk through the scenario and manually to have an idea of what the test steps will need to do, the elements you'll need to interact with and how you're going to need to interact with them. I found it helps to properly define the steps taken in the scenario and the different user interactions that are needed to accomplish it. 
+
+You'd just add a new scenario to the test file as well that would look something like, 
+
+```javscript
+it( 'should be able to do something', async () => {
+	// Code to do something... 
+} );
+```
+
+That first parameter in the block above is where you'd put a short description of the scenario while the next parameter is the code you'd like to execute.
+
+### Second, figure out how to find the elements
+
+- The UI tests rely on locator strategies to identify elements... There's a number of locator strategies available to use and [this blog post](https://saucelabs.com/blog/advanced-locator-strategies) describes in a little more detail what a few of these are and how to use them. You'll need to start thinking about what locator strategy you'll need to use to find the elements you need if it isn't already available. 
+- The preferred strategy is the accessibility identifier and in a lot of cases this might not be possible and you'll have to resort to other less robust alternatives such as XPath. 
+
+There's a few tools you have available to figure out what you need. 
+
+For Android, you can fire up the app and then within Android Studio select `Tools -> Layout Inspector` which will then open up a `.li` file which you can then use to inspect various areas of the app, here's a [screenshot](https://d.pr/free/i/anU50R) of what that looks like. 
+
+For iOS, you can also fire up and use the accessibility inspector, which is an app that should come available on your OSX machine. From there you can choose the process running your simulator and inspect various areas of the app. 
+
+Alternative for both of these platforms and for an interface to simulate the commands I'd recommend [Appium Desktop](https://github.com/appium/appium-desktop/releases/tag/v1.12.1). A great tool for inspecting the view hierarchy and interacting with elements on screen as your test would. Here's a [screenshot](https://d.pr/free/i/GziQ5Q) of what that would look like. 
+
+Using one or a combination of these tools will make it much easier to identify what locator strategy you're going to use or which elements need accessibility identifiers to ease the search process without affecting VoiceOver features. 
+
+### Finally, once you've figured out how you're going to find the elements
+
+- You'll write any functions needed to interact with the page in the `EditorPage` page object and then call those interactions within the test. The code you'll need to write to actually do the finding will use a combination of
+
+- Appium's spec http://appium.io/docs/en/about-appium/intro/ which you can find examples of a variety of functions under the commands tab
+- WebDriver I/O Appium protocols https://webdriver.io/docs/api/appium.html which provides examples and descriptions of what those look like. 
+
+It takes some getting use to but looking at the existing code should be helpful in identifying common commands that it'd help to be familiar with. 

__device-tests__/README.md

@@ -0,0 +1,56 @@
+# Overview
+
+We use [appium](http://appium.io/) combined with [SauceLabs](https://saucelabs.com/) as an on-device testing solution for covering writing flows using Gutenberg blocks.
+
+Appium is built on the idea that testing native apps shouldn't require including an SDK or recompiling your app. And that you should be able to use your preferred test practices, frameworks, and tools. Appium is an open source project and has made design and tool decisions to encourage a vibrant contributing community.
+
+SauceLabs is a cloud hosting platform that provides access to a variety of simulators, emulators and real devices. 
+
+## Getting set up to run the tests
+
+### Emulators && Simulators
+
+iOS: Once you've already set up XCode and the simulators you should be good to go to run the tests on an iOS simulator.
+
+Android: You'll need to have created the emulator images and fired up the desired emulator before running the tests against an Android emulator. 
+
+### Real Devices 
+
+TBA
+
+## Running the tests locally
+
+TLDR; to run the tests locally ensure metro isn't running and then run `yarn test:e2e:ios:local` and `yarn test:e2e:android:local` for the desired platform.
+
+Those commands include the process to build a testable version of the app, if it's the case you don't want to run the 
+full suite and want to run a specific file or files you can use the e2e build commands that can be found in the package.json for the respective platform and then 
+run `TEST_RN_PLATFORM=android yarn device-tests <pattern>` where the pattern can just be the file path.
+
+### Starting the Appium Server
+
+One of the Caveats to using Appium is the need for the Appium server to be running to interact with the Simulator or Device through Webdriver, as a result the appium server will need to be started before running the tests. To make the entire process easier in the `beforeAll` block of the tests an Appium instance is fired up on a default port of 4723. If you already have something running on that port and would rather not stop that you can change the port within the code that starts that up. At the moment that port number is referenced from the config located at `__device-tests__/helpers/serverConfigs.js`. The process is killed in the `afterAll` block but at the time of writing this there's a small chance  some errors might cause it not to get there so it might be best to kill the process yourself if you think something is up. The server output when running the tests are written to `appium-out.log`, this can provide useful information when debugging the issues with the tests. 
+
+### WebDriver capabilities 
+
+Appium uses a config object that contains `capabilities` to define how it will connect to a simulator or device, this object is currently located in `__device-tests__/helpers/caps.js` and then referenced when firing up the driver. There are two values that I think are important to know and that's
+
+- `platformVersion` which is the platform version of a connected adb device. e.g `9.0` for Android or `12.2` for iOS. The version used here is upper bounded by the max allowed on CI but feel free to change this value locally as needed. 
+- `app` which is the absolute path to the `.app` or `.apk` file or the path relative to the **Appium root**. It's important to note that that when using the relative paths it's not to the project folder but to the appium server, since by default we start up appium in the project root when running the paths appear relative to the root but if you were using another instance of the Appium server the relative path would need to come from there.  
+
+A full spec on the capabilities can be found [here](http://appium.io/docs/en/writing-running-appium/caps/). If you'd like to change configurations like
+what port appium runs on or what device or emulator the tests should be executed on that file would be where you'd like to make that update.
+
+## The run process 
+
+At the moment when running locally, the app attempts to fire up an appium server and then connects to it via webdriver. Then 
+
+* on Android, a debug version of the app is bundled, built, and used. 
+* on iOS a release version is bundled built and used. 
+
+**It's important to ensure that **metro is not running.** This would cause the value of the `__DEV__` variable to be true and load up the sample blocks.** 
+
+After the build is complete, an appium server is fired up on port 4723 and the device tests are ran on the connected device/simulator. 
+
+-----
+
+To read more about writing your own tests please read the [contributing guide](https://github.com/wordpress-mobile/gutenberg-mobile/blob/develop/__device-tests__/CONTRIBUTING.md)

__device-tests__/gutenberg-editor-block-insertion.test.js

@@ -0,0 +1,114 @@
+/**
+ * @format
+ * */
+
+/**
+ * Internal dependencies
+ */
+import EditorPage from './pages/editor-page';
+import {
+	setupDriver,
+	isLocalEnvironment,
+	stopDriver,
+	isAndroid,
+	clickMiddleOfElement,
+} from './helpers/utils';
+import testData from './helpers/test-data';
+
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 300000;
+
+describe( 'Gutenberg Editor tests for Block insertion', () => {
+	let driver;
+	let editorPage;
+	let allPassed = true;
+
+	// Use reporter for setting status for saucelabs Job
+	if ( ! isLocalEnvironment() ) {
+		const reporter = {
+			specDone: async ( result ) => {
+				allPassed = allPassed && result.status !== 'failed';
+			},
+		};
+
+		jasmine.getEnv().addReporter( reporter );
+	}
+
+	beforeAll( async () => {
+		driver = await setupDriver();
+		editorPage = new EditorPage( driver );
+	} );
+
+	it( 'should be able to see visual editor', async () => {
+		await expect( editorPage.getBlockList() ).resolves.toBe( true );
+	} );
+
+	it( 'should be able to insert block into post', async () => {
+		await editorPage.addNewParagraphBlock();
+		let paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 1 );
+		if ( isAndroid() ) {
+			await paragraphBlockElement.click();
+		}
+		await editorPage.sendTextToParagraphBlockAtPosition( 1, testData.longText );
+		// Should have 3 paragraph blocks at this point
+
+		paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 2 );
+		await paragraphBlockElement.click();
+
+		await editorPage.addNewParagraphBlock();
+		paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 3 );
+		await paragraphBlockElement.click();
+		await editorPage.sendTextToParagraphBlockAtPosition( 3, testData.mediumText );
+
+		await editorPage.verifyHtmlContent( testData.blockInsertionHtml );
+
+		// Workaround for now since deleting the first element causes a crash on CI for Android
+		if ( isAndroid() ) {
+			paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 3 );
+			await paragraphBlockElement.click();
+			await editorPage.removeParagraphBlockAtPosition( 3 );
+			for ( let i = 3; i > 0; i-- ) {
+				paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( i );
+				await paragraphBlockElement.click();
+				await editorPage.removeParagraphBlockAtPosition( i );
+			}
+		} else {
+			for ( let i = 4; i > 0; i-- ) {
+				paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 1 );
+				await clickMiddleOfElement( driver, paragraphBlockElement );
+				await editorPage.removeParagraphBlockAtPosition( 1 );
+			}
+		}
+	} );
+
+	it( 'should be able to insert block at the beginning of post from the title', async () => {
+		await editorPage.addNewParagraphBlock();
+		let paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 1 );
+		if ( isAndroid() ) {
+			await paragraphBlockElement.click();
+		}
+		await editorPage.sendTextToParagraphBlockAtPosition( 1, testData.longText );
+		// Should have 3 paragraph blocks at this point
+
+		if ( isAndroid() ) {
+			await driver.hideDeviceKeyboard();
+		}
+
+		const titleElement = await editorPage.getTitleElement();
+		await titleElement.click();
+		await titleElement.click();
+
+		await editorPage.addNewParagraphBlock();
+		paragraphBlockElement = await editorPage.getParagraphBlockAtPosition( 1 );
+		await clickMiddleOfElement( driver, paragraphBlockElement );
+		await editorPage.sendTextToParagraphBlockAtPosition( 1, testData.mediumText );
+		await paragraphBlockElement.click();
+		await editorPage.verifyHtmlContent( testData.blockInsertionHtmlFromTitle );
+	} );
+
+	afterAll( async () => {
+		if ( ! isLocalEnvironment() ) {
+			driver.sauceJobStatus( allPassed );
+		}
+		await stopDriver( driver );
+	} );
+} );

__device-tests__/gutenberg-editor-heading.test.js

@@ -14,7 +14,7 @@ import {
 } from './helpers/utils';
 import testData from './helpers/test-data';
 
-jasmine.DEFAULT_TIMEOUT_INTERVAL = 240000;
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 300000;
 
 describe( 'Gutenberg Editor tests', () => {
 	let driver;

__device-tests__/gutenberg-editor-image.test.js

@@ -16,7 +16,7 @@ import {
 } from './helpers/utils';
 import testData from './helpers/test-data';
 
-jasmine.DEFAULT_TIMEOUT_INTERVAL = 240000;
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 300000;
 
 describe( 'Gutenberg Editor Image Block tests', () => {
 	let driver;
@@ -63,6 +63,7 @@ describe( 'Gutenberg Editor Image Block tests', () => {
 			await swipeUp( driver, imageBlock );
 			await editorPage.enterCaptionToSelectedImageBlock( testData.imageCaption );
 			await editorPage.dismissKeyboard();
+			imageBlock = await editorPage.getImageBlockAtPosition( 1 );
 			await imageBlock.click();
 		}
 		await editorPage.removeImageBlockAtPosition( 1 );

__device-tests__/gutenberg-editor-lists-end.test.js

@@ -14,7 +14,7 @@ import {
 } from './helpers/utils';
 import testData from './helpers/test-data';
 
-jasmine.DEFAULT_TIMEOUT_INTERVAL = 240000;
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 300000;
 
 describe( 'Gutenberg Editor tests for List block (end)', () => {
 	let driver;

__device-tests__/gutenberg-editor-lists.test.js

@@ -14,7 +14,7 @@ import {
 } from './helpers/utils';
 import testData from './helpers/test-data';
 
-jasmine.DEFAULT_TIMEOUT_INTERVAL = 240000;
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 300000;
 
 describe( 'Gutenberg Editor tests for List block', () => {
 	let driver;

__device-tests__/gutenberg-editor-paragraph.test.js

@@ -16,7 +16,7 @@ import {
 } from './helpers/utils';
 import testData from './helpers/test-data';
 
-jasmine.DEFAULT_TIMEOUT_INTERVAL = 250000;
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 300000;
 
 describe( 'Gutenberg Editor tests for Paragraph Block', () => {
 	let driver;

__device-tests__/gutenberg-editor-paste.test.js

@@ -18,7 +18,7 @@ import {
 } from './helpers/utils';
 import testData from './helpers/test-data';
 
-jasmine.DEFAULT_TIMEOUT_INTERVAL = 240000;
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 300000;
 
 describe( 'Gutenberg Editor paste tests', () => {
 	// skip iOS for now