Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #606
This PR fixes the dictation content disappearing from Paragraph blocks on iOS.
This is why the issue happens:
textViewDidChange
is called with the new text. (NoinsertText
) is called.textViewDidChange
is called first with the text existing previous the dictation (an empty string in this case).textViewDidChange
is called again with the full new text. (and RNAztec informs again the JS side)setContents
message from JS from the previous propagation of the empty string. Since JS resetseventCount
to zero (undefined) when the string is empty, RNAztec refresh its state to an empty string, and the dictation string is lost.setContents
message from JS with the dictation string, but it's ignored since it haseventCount == 1
To fix the issue, I noticed that the step 3 is always called between
dictationRecordingDidEnd
andinsertDictationResult
.Activating a flag in between those method calls to avoid propagating the empty string fixed the issue.
To test: