RNAztec iOS: Fix removing content after dictation #700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #673
This issue was originally fixed here #610, but it resurfaced.
The original fix was blocking the empty strings to be sent from
textViewDidChange
to the RN side, when UIKit was inserting the dictation text. That empty string was finally overwriting the content when it was sent back from RN to Native, since with an empty string, the JS side nullifies theeventCount
.I noticed that in this case, the same was happening on
textViewDidChangeSelection
, so using the same strategy there solved the problem.As discussed in the original PR, this is not the best fix, but a better solution will probably involve all platforms. If this continue being an issue in the future, I'd suggest to give some time to find that better solution.
To test: