Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ロックダウン機能を削除 #650

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Feb 27, 2025

What

設定>プライバシー>ロックダウンを項目ごと削除する

Why

連合機能として不利
リモートユーザーに多大な不便を生じさせる

Additional info (optional)

リモートから来た該当設定はリモートの意図を尊重するため、設定を反映する

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Feb 27, 2025

이 PR에 의한 api.json 차이
차이점이 없습니다.
Get diff files from Workflow Page

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 35.56%. Comparing base (462f92e) to head (4df2548).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...kages/backend/src/server/api/endpoints/i/update.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #650      +/-   ##
===========================================
- Coverage    39.40%   35.56%   -3.84%     
===========================================
  Files         1765     1761       -4     
  Lines       249827   243413    -6414     
  Branches      4446     3065    -1381     
===========================================
- Hits         98444    86570   -11874     
- Misses      150713   156134    +5421     
- Partials       670      709      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 marked this pull request as ready for review February 27, 2025 00:40
@kozakura913 kozakura913 self-assigned this Feb 27, 2025
@kozakura913 kozakura913 added this to the 1.4.0 milestone Feb 27, 2025
@kozakura913 kozakura913 merged commit 58ef24e into yojo-art:develop Feb 28, 2025
18 of 20 checks passed
@kozakura913 kozakura913 mentioned this pull request Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants