Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 1.4.0 #669

Merged
merged 714 commits into from
Mar 16, 2025
Merged

Release: 1.4.0 #669

merged 714 commits into from
Mar 16, 2025

Conversation

kozakura913
Copy link
Collaborator

1.4.0

Cherrypick 4.15.0
Misskey 2025.2.0

Release Date

2025-03-16

General

  • Fix: リポジトリURLとフィードバックURLを変更(改変版を利用してると表示される問題も修正) #666
  • Feat: リモートインスタンスのソフトウェア一覧 #659
    - エンドポイント:api/federation/remote-software
    • フロントエンドでは/about#charts で確認できます
  • Change: ロックダウン機能を削除 #650
    • リモートユーザーの設定は反映します

Client

  • Fix: yojo-art アップデートを開くとサーバー設定が更新される問題を修正 #651
  • Fix: 非ログインでローカル/グローバルタイムラインが表示できない不具合の修正 #667
  • Feat: リアクション付ける前に確認ダイアログを追加するオプション #657
  • Change: 投稿フォームのUI変更 #655

Server

  • Fix: リモートのイベントを表示できるように #658
  • Change: api/i/notifications-groupedで新着ノートをデフォルトでまとめないように#662
  • Enhance: 通常の検索でもOpenSearchを利用できるように #661

kakkokari-gtyih and others added 30 commits February 3, 2025 13:45
* fix: disallow corepack from fetching latest manager version instead use specified version in package.json

* Update Changelog

* fix?

* apply COREPACK_DEFAULT_TO_LATEST: 0 to every github workflows

* Revert "apply COREPACK_DEFAULT_TO_LATEST: 0 to every github workflows"

This reverts commit 67f0dc31adaa04f891f74f5c44a3d4d13a302a03.

* apply COREPACK_DEFAULT_TO_LATEST: 0 to every github workflows (re)

* fix

* fix?

* revert: removing corepack enable

* test: set COREPACK_DEFAULT_TO_LATEST for federation tests

---------

Co-authored-by: Marie <github@yuugi.dev>
Co-authored-by: anatawa12 <anatawa12@icloud.com>
* fix(frontend): MkSparkleが動作しない問題を修正

* Update Changelog

* fix

* add comments
* fix(frontend): スラッシュを含むページを閲覧できるように

* Update Changelog

* fix
Co-authored-by: おさむのひと <46447427+samunohito@users.noreply.github.com>
* wip

* paramの正規表現で弾くように

* apiWithDialogを使用するように

* Update CHANGELOG.md

---------

Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com>
* New translations ja-jp.yml (Russian)

* New translations ja-jp.yml (Catalan)

* New translations ja-jp.yml (Korean)

* New translations ja-jp.yml (Portuguese)

* New translations ja-jp.yml (Chinese Traditional)

* New translations ja-jp.yml (English)

* New translations ja-jp.yml (Japanese, Kansai)

* New translations ja-jp.yml (French)

* New translations ja-jp.yml (Spanish)

* New translations ja-jp.yml (Arabic)

* New translations ja-jp.yml (Czech)

* New translations ja-jp.yml (German)

* New translations ja-jp.yml (Italian)

* New translations ja-jp.yml (Polish)

* New translations ja-jp.yml (Slovak)

* New translations ja-jp.yml (Ukrainian)

* New translations ja-jp.yml (Chinese Simplified)

* New translations ja-jp.yml (Vietnamese)

* New translations ja-jp.yml (Indonesian)

* New translations ja-jp.yml (Bengali)

* New translations ja-jp.yml (Thai)

* New translations ja-jp.yml (Uzbek)
* fix(frontend): デッキのプロファイルが保存できない問題を修正

* Update Changelog

* Update CHANGELOG.md
* wip

* wip

* wip

* wip

* revert unnecessary changes

* wip

* refactor(frontend): enforce verbatimModuleSyntax

* fix

* refactor(frontend-shared): enforce verbatimModuleSyntax

* wip

* refactor(frontend-embed): enforce verbatimModuleSyntax

* enforce consistent-type-imports

* fix lint config

* attemt to fix ci

* fix lint

* fix

* fix

* fix
* refactor(frontend): remove X theme properties

* Update MkAutocomplete.vue

* Update WidgetCalendar.vue
  - 자신의 프로필 아이콘 모양<small>(원형, 사각형)</small>을 로컬 사용자 및 원격 사용자에게 연합시킬 수 있습니다.
    - 로컬 사용자 뿐만 아니라, CherryPick `4.15.0` 이상 버전을 사용하는 서버에서는 해당 사용자가 지정한 모양으로 프로필이 표시됩니다.
  - CherryPick `4.15.0` 이상 버전을 사용하는 서버에서만 이 기능을 사용할 수 있습니다.
  - 이 설정은 서버마다 추구하는 방향이 다를 수 있기 때문에, 역할에서 `프로필 아이콘 모양 설정 연합 허용`이 제한되지 않은 상태에서만 사용할 수 있습니다.
    - 이 역할이 꺼져있으면 프로필 아이콘 모양 설정이 연합되지 않으며, 모든 사용자의 프로필 아이콘 모양이 `프로필 아이콘을 사각형으로 표시` 설정에 따라 표시됩니다.
  - 기본 `robots.txt`에 정의된 내용을 사용자화 할 수 있습니다.
noridev and others added 18 commits February 28, 2025 12:45
# Conflicts:
#	locales/ar-SA.yml
#	locales/bn-BD.yml
#	locales/el-GR.yml
#	locales/en-US.yml
#	locales/es-ES.yml
#	locales/fr-FR.yml
#	locales/id-ID.yml
#	locales/index.d.ts
#	locales/it-IT.yml
#	locales/ja-JP.yml
#	locales/ja-KS.yml
#	locales/ko-KR.yml
#	locales/pl-PL.yml
#	locales/ru-RU.yml
#	locales/sk-SK.yml
#	locales/uk-UA.yml
#	locales/vi-VN.yml
#	locales/zh-CN.yml
#	locales/zh-TW.yml
#	package.json
#	packages/backend/migration/1711722198590-no-recursive-delete.js
#	packages/backend/migration/1720161864577-AddDeleteAt.js
#	packages/backend/package.json
#	packages/backend/src/boot/master.ts
#	packages/backend/src/core/CustomEmojiService.ts
#	packages/backend/src/core/activitypub/ApRendererService.ts
#	packages/backend/src/core/activitypub/ApResolverService.ts
#	packages/backend/src/queue/processors/ScheduledNoteDeleteProcessorService.ts
#	packages/backend/src/server/api/endpoints/notes/bubble-timeline.ts
#	packages/backend/src/server/web/views/base.pug
#	packages/backend/src/server/web/views/error.pug
#	packages/cherrypick-js/package.json
#	packages/cherrypick-js/src/autogen/types.ts
#	packages/frontend/package.json
#	packages/frontend/src/boot/common.ts
#	packages/frontend/src/components/MkDice.vue
#	packages/frontend/src/components/MkMediaVideo.vue
#	packages/frontend/src/components/MkNote.vue
#	packages/frontend/src/components/MkNoteDetailed.vue
#	packages/frontend/src/components/MkNotification.vue
#	packages/frontend/src/components/MkPostForm.vue
#	packages/frontend/src/components/MkPostFormSimple.vue
#	packages/frontend/src/components/MkQRCode.vue
#	packages/frontend/src/components/MkScheduledNoteDelete.vue
#	packages/frontend/src/components/index.ts
#	packages/frontend/src/local-storage.ts
#	packages/frontend/src/pages/admin/index.vue
#	packages/frontend/src/pages/channel.vue
#	packages/frontend/src/pages/note.vue
#	packages/frontend/src/pages/search.note.vue
#	packages/frontend/src/pages/search.user.vue
#	packages/frontend/src/scripts/get-note-menu.ts
#	packages/frontend/src/ui/_common_/navbar-for-mobile.vue
#	packages/frontend/src/ui/_common_/navbar.vue
#	packages/frontend/src/ui/classic.header.vue
#	packages/frontend/src/ui/classic.sidebar.vue
#	packages/frontend/src/ui/deck/channel-column.vue
#	packages/frontend/src/ui/friendly/navbar-for-mobile.vue
#	packages/frontend/src/ui/friendly/navbar.vue
#	packages/frontend/src/widgets/WidgetDice.vue
#	packages/frontend/src/widgets/index.ts
#	packages/frontend/test/url-preview.test.ts
#	pnpm-lock.yaml
@@ -18,6 +18,15 @@
import { appendQuery, query } from '@/misc/prelude/url.js';
import type { Config } from '@/config.js';

// TODO:

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
) {
if (noteDrafts.length === 0) return [];

// TODO: 本当は renote とか reply がないのに renoteId とか replyId があったらここで解決しておく

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
})
public hasEvent: boolean;

// TODO: varcharにしたい(Note.tsと同じ)

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
private noteDraftEntityService: NoteDraftEntityService,
) {
super(meta, paramDef, async (ps, me) => {
// TODO: ノートendpointのバリデーションとServiceとして共通化

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
throw new ApiError(meta.errors.accessDenied);
}

// TODO: ノートendpointのバリデーションとServiceとして共通化

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
},
);
/**
* FIXME: not delivered

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note test

Suspicious comment
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

Attention: Patch coverage is 62.46981% with 1243 lines in your changes missing coverage. Please review.

Project coverage is 41.04%. Comparing base (fb96525) to head (03a7673).
Report is 736 commits behind head on master.

Files with missing lines Patch % Lines
packages/backend/src/core/SearchService.ts 15.38% 154 Missing ⚠️
...ackend/src/core/entities/NoteDraftEntityService.ts 29.56% 131 Missing ⚠️
packages/backend/src/core/NoteDraftService.ts 32.72% 111 Missing ⚠️
...es/backend/src/core/entities/EmojiEntityService.ts 9.19% 79 Missing ⚠️
...ges/backend/src/core/activitypub/ApInboxService.ts 2.59% 75 Missing ⚠️
packages/backend/src/core/AdvancedSearchService.ts 21.50% 73 Missing ⚠️
packages/backend/src/core/HttpRequestService.ts 57.22% 69 Missing and 2 partials ⚠️
...ges/backend/src/core/entities/NoteEntityService.ts 4.34% 66 Missing ⚠️
...ckages/backend/src/core/AvatarDecorationService.ts 21.51% 62 Missing ⚠️
packages/backend/src/core/CustomEmojiService.ts 77.82% 51 Missing ⚠️
... and 46 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   39.99%   41.04%   +1.04%     
==========================================
  Files        1698     1776      +78     
  Lines      236730   194121   -42609     
  Branches     3906     4370     +464     
==========================================
- Hits        94691    79683   -15008     
+ Misses     141373   113905   -27468     
+ Partials      666      533     -133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

api.json 간 차이점을 생성하는 도중 오류가 발생했습니다. 자세한 내용은 Workflow 로그를 확인해 주세요.

*/
@bindThis
public async enqueueUserWebhook<T extends WebhookEventTypes>(
userId: MiUser['id'],

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
in a security context.
This uses a cryptographically insecure random number generated at
Math.random()
in a security context.
This uses a cryptographically insecure random number generated at
Math.random()
in a security context.

Copilot Autofix AI 4 days ago

To fix the problem, we need to replace the use of Math.random() with a cryptographically secure random number generator. In Node.js, we can use the crypto module to generate secure random values. Specifically, we can use crypto.randomBytes to generate random bytes and convert them to hexadecimal strings.

  • Replace the getRandom function in packages/backend/src/misc/id/meid.ts to use crypto.randomBytes instead of Math.random().
  • Ensure that the new implementation maintains the same functionality of generating a 12-character hexadecimal string.
Suggested changeset 1
packages/backend/src/misc/id/meid.ts
Outside changed files

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/backend/src/misc/id/meid.ts b/packages/backend/src/misc/id/meid.ts
--- a/packages/backend/src/misc/id/meid.ts
+++ b/packages/backend/src/misc/id/meid.ts
@@ -21,10 +21,6 @@
 
-function getRandom() {
-	let str = '';
-
-	for (let i = 0; i < 12; i++) {
-		str += CHARS[Math.floor(Math.random() * CHARS.length)];
-	}
+import { randomBytes } from 'crypto';
 
-	return str;
+function getRandom() {
+	return randomBytes(6).toString('hex');
 }
EOF
@@ -21,10 +21,6 @@

function getRandom() {
let str = '';

for (let i = 0; i < 12; i++) {
str += CHARS[Math.floor(Math.random() * CHARS.length)];
}
import { randomBytes } from 'crypto';

return str;
function getRandom() {
return randomBytes(6).toString('hex');
}
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@kozakura913 kozakura913 merged commit 80a02ad into master Mar 16, 2025
46 of 50 checks passed
@kozakura913 kozakura913 added this to the 1.4.0 milestone Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.