Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api/i/notifications-groupedで新着ノートをデフォルトでまとめないように #662

Merged
merged 4 commits into from
Mar 16, 2025

Conversation

penginn-net
Copy link
Collaborator

What

Close #625

Why

サードパーティクライアント互換性

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.90%. Comparing base (49bed1e) to head (eed78f9).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/server/api/endpoints/i/notifications-grouped.ts 50.00% 1 Missing ⚠️
...ckages/frontend/src/components/MkNotifications.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #662      +/-   ##
===========================================
+ Coverage    41.04%   42.90%   +1.85%     
===========================================
  Files         1776     1780       +4     
  Lines       194125   200498    +6373     
  Branches      4365     4402      +37     
===========================================
+ Hits         79681    86022    +6341     
- Misses      113911   113943      +32     
  Partials       533      533              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 9, 2025

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -52998,6 +52998,11 @@
                     "type": "boolean",
                     "default": true
                   },
+                  "groupNote": {
+                    "type": "boolean",
+                    "default": false,
+                    "description": "新着ノート通知をまとめるか"
+                  },
                   "includeTypes": {
                     "type": "array",
                     "items": {

Get diff files from Workflow Page

@penginn-net penginn-net requested a review from kozakura913 March 14, 2025 04:31
@@ -7,6 +7,7 @@ Misskey 2025.2.0
### General
- ロックダウン機能を削除 [#650](https://github.com/yojo-art/cherrypick/pull/650)
- リモートユーザーの設定は反映します
- `api/i/notifications-grouped`で新着ノートをデフォルトでまとめないように
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR番号欠けてる

@penginn-net penginn-net requested a review from kozakura913 March 16, 2025 01:41
@penginn-net penginn-net merged commit abff515 into yojo-art:develop Mar 16, 2025
35 checks passed
@kozakura913 kozakura913 mentioned this pull request Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

通知取得エンドポイントの新着投稿をまとめるかにフラグを生やす?
2 participants