Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client methods #113

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add client methods #113

wants to merge 1 commit into from

Conversation

cmurphy
Copy link
Contributor

@cmurphy cmurphy commented Mar 18, 2025

Add a client support package. This will be used in Rekor's integration tests and can be imported by Go-based Sigstore clients.

Depends on #119

TODO:

Summary

Release Note

Documentation

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 90 lines in your changes missing coverage. Please review.

Project coverage is 26.25%. Comparing base (82230be) to head (875a7c4).

Files with missing lines Patch % Lines
pkg/note/note.go 22.72% 32 Missing and 2 partials ⚠️
pkg/client/write.go 75.47% 18 Missing and 8 partials ⚠️
pkg/client/read.go 52.63% 16 Missing and 2 partials ⚠️
pkg/client/common.go 68.42% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   21.61%   26.25%   +4.64%     
==========================================
  Files          27       31       +4     
  Lines        1712     1935     +223     
==========================================
+ Hits          370      508     +138     
- Misses       1308     1378      +70     
- Partials       34       49      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


type Option func(*clientConfig)

func WithUserAent(agent string) Option {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func WithUserAent(agent string) Option {
func WithUserAgent(agent string) Option {

@cmurphy
Copy link
Contributor Author

cmurphy commented Mar 20, 2025

Will rebase on #114 once merged and replace verifyTLE with verify.VerifyLogEntry.

@jku
Copy link
Member

jku commented Mar 21, 2025

Will rebase on #114 once merged and replace verifyTLE with verify.VerifyLogEntry.

That is #119 now. I might not have time to get the tests done for that today: if you are in a hurry with this one feel free to use that branch here or merge it, just file an issue so I remember to write those tests...

Add a client support package. This will be used in Rekor's integration
tests and can be imported by Go-based Sigstore clients.

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants