Remove action mailer dependency #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other than my two minor suggestions, this looks good to me. 👍 |
erkde
force-pushed
the
remove_action_mailer_dependency
branch
from
57c90fc to
0d2805b
Compare
Even though the Gemfile.lock includes action_mailer as part of the Rails dependency, we don’t have to load it and can save a little memory by not doing so.
erkde
force-pushed
the
remove_action_mailer_dependency
branch
from
0d2805b to
f35a7fe
Compare
|
Have just rebased this with master |
erkde
pushed a commit
that referenced
this pull request
Mar 11, 2016
Remove action mailer dependency
This was referenced Mar 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't appear smart answers uses any of the Rails mailer functionality, so this PR removes the requiring of the
action_mailergem that is in the project Gemfile.lock via therailsdependency, and removes the mailer related config and directory in the application.For further detail regarding why
action_mailermay exist in smart_answers (along with other gov.uk projects) see alphagov/frontend#930