Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Remove action mailer dependency"" #2366

Merged

Conversation

erkde
Copy link
Contributor

@erkde erkde commented Mar 14, 2016

The deploy script (private repo) for smart answers and the frontend app is now updated to remove the deploy task that copied the file mailer.rb, containing GDS mailer config, into the config/initializers as a post deploy task.

Reverts #2357, which reverted the original PR /pull/2348 to remove action_mailer from smart answers.

@chrisroos
Copy link
Contributor

Can you update the description to explain why we're able to merge this again? Presumably the thing that initially caused problems in #2357 has now been fixed/removed?

@chrisroos chrisroos self-assigned this Mar 15, 2016
@erkde
Copy link
Contributor Author

erkde commented Mar 15, 2016

thanks @chrisroos - have updated the description

@chrisroos
Copy link
Contributor

Thanks for updating the description, @erikse.

Are we confident that deploying this won't cause any problems now that the related initializer has been removed? If we're unsure, is there any way of boosting confidence before we merge/deploy?

I'm happy for this to be merged if/when we're confident it's not going to cause any problems after deploying.

@chrisroos chrisroos added the LGTM label Mar 15, 2016
@erkde
Copy link
Contributor Author

erkde commented Mar 16, 2016

Yeah, last time we saw an error in Errbit when it was deployed to integration by CI so I'd imagine we would see that again if for some reason the PR @mattbostock merged has been reverted, or missed updating the smart answers script.

@erkde erkde force-pushed the revert-2357-revert-2348-remove_action_mailer_dependency branch from c081119 to d9f50a7 Compare March 16, 2016 04:07
erkde pushed a commit that referenced this pull request Mar 16, 2016
…_action_mailer_dependency

Revert "Revert "Remove action mailer dependency""
@erkde erkde merged commit b7be602 into master Mar 16, 2016
@erkde erkde deleted the revert-2357-revert-2348-remove_action_mailer_dependency branch March 16, 2016 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants