Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove action mailer dependency" #2357

Merged
merged 1 commit into from
Mar 11, 2016
Merged

Revert "Remove action mailer dependency" #2357

merged 1 commit into from
Mar 11, 2016

Conversation

erkde
Copy link
Contributor

@erkde erkde commented Mar 11, 2016

Reverts #2348

There seems to be a post deploy task that currently copies an initialiser ruby with action_mailer related configuration into the smart answers config/intialisers directory, which causes all the subsequent post-deploy tasks to fail afterwards, for example - as seen on integration:

ERROR MESSAGE:
NameError: uninitialized constant ActionMailer

WHERE:
rake#RAILS_ENV=production RAILS_GROUPS=assets assets:precompile


URL:
BROWSER:
100.0%  N/A


FULL BACKTRACE:
/data/vhost/smartanswers.integration.publishing.service.gov.uk/releases/20160311160629/config/initializers/mailer.rb:1
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/engine.rb:652
[GEM_ROOT]/gems/activesupport-4.2.6/lib/active_support/notifications.rb:166
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/engine.rb:651
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/engine.rb:616
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/engine.rb:615
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/engine.rb:615
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/initializable.rb:30
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/initializable.rb:30
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/initializable.rb:55
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:228
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:350
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:422
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:431
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:421
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/initializable.rb:44
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/initializable.rb:44
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:415
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:415
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:349
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:347
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:347
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:347
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:226
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/tsort.rb:205
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/initializable.rb:54
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/application.rb:352
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/railtie.rb:194
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/railtie.rb:194
/data/vhost/smartanswers.integration.publishing.service.gov.uk/releases/20160311160629/config/environment.rb:5
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/application.rb:328
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/application.rb:328
[GEM_ROOT]/gems/railties-4.2.6/lib/rails/application.rb:457
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:240
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:235
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:235
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:179
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/monitor.rb:214
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:172
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:165
[GEM_ROOT]/gems/sprockets-rails-3.0.4/lib/sprockets/rails/task.rb:62
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:240
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:235
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:235
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:179
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/monitor.rb:214
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:172
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:201
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:199
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:199
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:178
/usr/lib/rbenv/versions/2.3.0/lib/ruby/2.3.0/monitor.rb:214
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:172
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/task.rb:165
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/application.rb:150
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/application.rb:106
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/application.rb:106
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/application.rb:106
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/application.rb:115
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/application.rb:100
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/application.rb:78
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/application.rb:176
[GEM_ROOT]/gems/rake-10.5.0/lib/rake/application.rb:75
[GEM_ROOT]/gems/rake-10.5.0/bin/rake:33
[GEM_ROOT]/bin/rake:23
[GEM_ROOT]/bin/rake:23

This PR reverts the removal of action_mailer until that script has been updated.

@floehopper floehopper self-assigned this Mar 11, 2016
@floehopper
Copy link
Contributor

LGTM 👍

@erkde
Copy link
Contributor Author

erkde commented Mar 11, 2016

I've added a copy of the stack trace reported by Errbit that shows the error.

erkde pushed a commit that referenced this pull request Mar 11, 2016
@erikse
Merge pull request #2357 from alphagov/revert-2348-remove_action_mail…
fb5b673 
…er_dependency

Revert "Remove action mailer dependency"
@erkde erkde merged commit fb5b673 into master Mar 11, 2016
@erkde erkde mentioned this pull request Mar 14, 2016
Merged
@erkde erkde deleted the revert-2348-remove_action_mailer_dependency branch March 17, 2016 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@floehopper floehopper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erkde @floehopper @erikse