Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection list - use HubListToolbar, add sort #4507

Merged
merged 10 commits into from
Nov 29, 2023

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Nov 11, 2023

Follows #4368, #896, #4506, #4520, #4525
Related to AAH-2802, AAH-850

Adds CardListSwitcher support to HubListToolbar,
revamp CollectionFilter -> collectionFilter to return props for HubListToolbar,
replace Search & NamespaceDetail toolbars with HubListToolbar.

And allow sorting collections by name, namespace, pulp_created and version.

20231128231004
20231128231021

@github-actions github-actions bot added backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Nov 11, 2023
@himdel himdel force-pushed the toolbar-collections branch from cb9edce to df9bc64 Compare November 11, 2023 05:59
@himdel himdel removed backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Nov 11, 2023
@himdel himdel force-pushed the toolbar-collections branch 4 times, most recently from 11ed6e8 to 15e046e Compare November 12, 2023 03:16
@himdel himdel added the community comunity mode feature label Nov 12, 2023
@himdel himdel force-pushed the toolbar-collections branch from 35904d0 to 7028da9 Compare November 12, 2023 04:03
@himdel himdel mentioned this pull request Nov 13, 2023
@himdel himdel force-pushed the toolbar-collections branch from 7028da9 to ab9000d Compare November 18, 2023 01:44
@himdel himdel added the backport-4.9 This PR should be backported to stable-4.9 (2.4) label Nov 21, 2023
@himdel himdel force-pushed the toolbar-collections branch from ab9000d to 1f254af Compare November 28, 2023 22:21
@himdel himdel marked this pull request as ready for review November 28, 2023 22:51
@himdel himdel merged commit cc0a5af into ansible:master Nov 29, 2023
@himdel himdel deleted the toolbar-collections branch November 29, 2023 00:42

This comment was marked as outdated.

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Nov 29, 2023
* collection list, namespace detail - use HubListToolbar

No-Issue

* CollectionFilter - repurpose for HubListToolbar

* HubListToolbar - add switcher, use in search

* CollectionFilter cleanup

* no more .hub-pagination-container, removing css

* no more .hub-toolbar-left, remove css

* fix Sort height when without Select

* sort by name, namespace, pulp_created, version

* remove unused exports

* hub-list-toolbar: add data-cy

(cherry picked from commit cc0a5af)
himdel added a commit that referenced this pull request Nov 29, 2023
* collection list, namespace detail - use HubListToolbar

No-Issue

* CollectionFilter - repurpose for HubListToolbar

* HubListToolbar - add switcher, use in search

* CollectionFilter cleanup

* no more .hub-pagination-container, removing css

* no more .hub-toolbar-left, remove css

* fix Sort height when without Select

* sort by name, namespace, pulp_created, version

* remove unused exports

* hub-list-toolbar: add data-cy

(cherry picked from commit cc0a5af)
@github-actions github-actions bot added the backported-4.9 This PR has been backported to stable-4.9 (2.4) label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4.9 This PR should be backported to stable-4.9 (2.4) backported-4.9 This PR has been backported to stable-4.9 (2.4) community comunity mode feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant