-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collection list - use HubListToolbar, add sort #4507
Merged
Merged
+168
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb9edce
to
df9bc64
Compare
11ed6e8
to
15e046e
Compare
himdel
commented
Nov 12, 2023
himdel
commented
Nov 12, 2023
35904d0
to
7028da9
Compare
7028da9
to
ab9000d
Compare
ab9000d
to
1f254af
Compare
This comment was marked as outdated.
This comment was marked as outdated.
himdel
added a commit
to himdel/ansible-hub-ui
that referenced
this pull request
Nov 29, 2023
* collection list, namespace detail - use HubListToolbar No-Issue * CollectionFilter - repurpose for HubListToolbar * HubListToolbar - add switcher, use in search * CollectionFilter cleanup * no more .hub-pagination-container, removing css * no more .hub-toolbar-left, remove css * fix Sort height when without Select * sort by name, namespace, pulp_created, version * remove unused exports * hub-list-toolbar: add data-cy (cherry picked from commit cc0a5af)
himdel
added a commit
that referenced
this pull request
Nov 29, 2023
* collection list, namespace detail - use HubListToolbar No-Issue * CollectionFilter - repurpose for HubListToolbar * HubListToolbar - add switcher, use in search * CollectionFilter cleanup * no more .hub-pagination-container, removing css * no more .hub-toolbar-left, remove css * fix Sort height when without Select * sort by name, namespace, pulp_created, version * remove unused exports * hub-list-toolbar: add data-cy (cherry picked from commit cc0a5af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-4.9
This PR should be backported to stable-4.9 (2.4)
backported-4.9
This PR has been backported to stable-4.9 (2.4)
community
comunity mode feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #4368, #896, #4506, #4520, #4525
Related to AAH-2802, AAH-850
Adds
CardListSwitcher
support toHubListToolbar
,revamp
CollectionFilter
->collectionFilter
to return props forHubListToolbar
,replace
Search
&NamespaceDetail
toolbars withHubListToolbar
.And allow sorting collections by name, namespace, pulp_created and version.