Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #4507
Our various APIs use
?sort
,?ordering
or?order_by
for sorting.Before:
BaseAPI
just usessort
(and only deals withpage
&page_size
->offset
&limit
mapping),PulpAPI
adds auseOrdering = false;
param, and overrideslist
to mapsort
toordering
depending on that,PulpAPI
subclasses setuseOrdering = true;
where applicable,LegacyAPI
adds asortParam = 'order_by';
and overrideslist
to mapsort
to that,LegacyAPI
subclasses settingsortParam
to eithersort
ororder_by
.After:
BaseAPI
setssortParam = 'sort';
, and mapssort
to the value ofsortParam
inlist
,PulpAPI
setssortParam = 'ordering';
,LegacyAPI
setssortParam = 'order_by';
,the exceptions being:
order_by
(notsort
)sort
(notordering
)sort
(notorder_by
)The only real change should be that
CollectionVersionSearchAPI
now usesorder_by
.