API: expand getUIPath, simplify base classes #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.7
himdel
removed
backport-4.7
…nt, except EE names)
…unning requests like upload
mostly because the onChange-based filter would really need a cancel token, but we want unified filters everywhere too
Backport to stable-4.9: 💚 backport PR created✅ Backport PR branch: Backported as #4577 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
* API: expand getUIPath, simplify base classes * separate apiPath (which can have slashes) from the rest (which shouldnt, except EE names) * getUsedDependencies - remove cancelToken, only practical for longer-running requests like upload * mapParams - replace mapPageToOffset calls with mapParams to also include sort * No-Issue * mapParams - make mapPageToOffset a bool * constructor cant read class variables * used by depenendencies - use HubListToolbar mostly because the onChange-based filter would really need a cancel token, but we want unified filters everywhere too (cherry picked from commit 71a1f11)
himdel
added a commit
that referenced
this pull request
Nov 25, 2023
* API: expand getUIPath, simplify base classes * separate apiPath (which can have slashes) from the rest (which shouldnt, except EE names) * getUsedDependencies - remove cancelToken, only practical for longer-running requests like upload * mapParams - replace mapPageToOffset calls with mapParams to also include sort * No-Issue * mapParams - make mapPageToOffset a bool * constructor cant read class variables * used by depenendencies - use HubListToolbar mostly because the onChange-based filter would really need a cancel token, but we want unified filters everywhere too (cherry picked from commit 71a1f11) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #4520
expand
getUIPath,move
API_HOSTtoBaseAPI,use
apiPathdirectly when applicable, fallback to''when undefined,move
sortParam = 'sort'toHubAPI, notBaseAPI.. all direct descendants set it,change
mapPageToOffsetto boolean,use
mapParams(page + sort) instead ofmapPageToOffsetmethod,remove cancel token from dependencies api (keep in upload),
use
HubListToolbarin dependencies tab (to prevent requests when typing)