Clear warning in the scene tree by creating an LightOccluder2D polygon #98637
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disappear fixes godotengine#21225 This commit fixes an UI bug which leads to a persistent warning in scene tree. Before this fix the only way to get rid of the warning was to reload the complete scene. The inspector issue mentioned in godotengine#21225 that polygon updates aren't reflected seems to be fixed in v4.3 and therefore not part of this commit.
fire
changed the title
clayjohn
approved these changes
Oct 30, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21225
This commit fixes an UI bug which leads to a persistent warning in scene tree. LightOccluder2D requires a polygon to work and shows a warning in scene tree when this polygon is absent. Adding a polygon did not clear this warning. Before this fix the only way to get rid of the warning was to reload the complete scene.
The inspector issue mentioned in #21225 that polygon updates aren't reflected seems to be fixed in v4.3 and is therefore not part of this commit.