Handle scene UIDs in MultiplayerSpawner #99137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
uideal_scenario
branch
from
98f68c1 to
46e1394
Compare
Summersay415
approved these changes
Nov 13, 2024
KoBeWi
force-pushed
the
uideal_scenario
branch
from
46e1394 to
d69011f
Compare
KoBeWi
force-pushed
the
uideal_scenario
branch
from
d69011f to
88b3090
Compare
|
@Faless still needs to review this a bit more closely, but we agreed to merge this as a stopgap solution for 4.4-dev5, and let Fabio re-review later to see if he'd prefer a different approach. |
akien-mga
approved these changes
Nov 19, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99116
The spawn issue occurred, because spawner will compare
scene_file_pathof a node with spawnable paths. Thus we either need to make sure that every path is a path, or convert scene path to UID for comparison.When SpawnableScenes are created, they get paths assigned, but they need to saved as UID. I'm keeping both values to avoid repeated conversions.