Fix UID support in MultiplayerSpawner #99712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
reviewed
Nov 27, 2024
KoBeWi
force-pushed
the
bug_spawner_spawns_new_bugs_to_fix
branch
from
ffba7c3 to
4fdb8ad
Compare
KoBeWi
force-pushed
the
bug_spawner_spawns_new_bugs_to_fix
branch
from
4fdb8ad to
67b95f3
Compare
akien-mga
approved these changes
Dec 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99706
The bug occurred because setting a path will use
_set()on path index, instead of_set_spawnable_scenes(). idk how I missed it previously.The main problem is that MultiplayerSpawner must operate on paths, but the editor wants it to store the paths as UID. I removed the uid field added in #99137. Now all paths are stored as paths internally, but saved as UID, with the conversion happening inside setters/getters. This might affect scene loading, but shouldn't impact performance of the spawner's operation.