-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chef rootnode_fan as sample device #22629
Add Chef rootnode_fan as sample device #22629
Conversation
Add Chef rootnode_fan as sample device including .zap / .matter / zzz-generated files
PR #22629: Size comparison from 8c4675f to 5c7b2ba Increases (10 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (4 builds for bl602, cc13x2_26x2, esp32, psoc6)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@erwinpan1 - please check the new file with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes: this is not a valid matter file:
it has a default for supported locales (which is an array and the default is en-us which is invalid).
when fixing this:
2022-09-15 10:36:11 ERROR ERROR: Required attributes: EP0:AccessControl does not expose SubjectsPerAccessControlEntry(2) attribute at /home/andrei/tmp/rootnode_fan_7N2TobIlOX.matter:1343:3
2022-09-15 10:36:11 ERROR ERROR: Required attributes: EP0:AccessControl does not expose TargetsPerAccessControlEntry(3) attribute at /home/andrei/tmp/rootnode_fan_7N2TobIlOX.matter:1343:3
2022-09-15 10:36:11 ERROR ERROR: Required attributes: EP0:AccessControl does not expose AccessControlEntriesPerFabric(4) attribute at /home/andrei/tmp/rootnode_fan_7N2TobIlOX.matter:1343:3
2022-09-15 10:36:11 ERROR ERROR: Required attributes: EP0:Basic does not expose CapabilityMinima(19) attribute at /home/andrei/tmp/rootnode_fan_7N2TobIlOX.matter:1351:3
2022-09-15 10:36:11 ERROR ERROR: Required attributes: EP0:LocalizationConfiguration does not expose ActiveLocale(0) attribute at /home/andrei/tmp/rootnode_fan_7N2TobIlOX.matter:1384:3
2022-09-15 10:36:11 ERROR ERROR: Required attributes: EP0:GeneralCommissioning does not expose SupportsConcurrentConnection(4) attribute at /home/andrei/tmp/rootnode_fan_7N2TobIlOX.matter:1398:3
2022-09-15 10:36:11 ERROR ERROR: Required attributes: EP0:Switch does not expose number of positions(0) attribute at /home/andrei/tmp/rootnode_fan_7N2TobIlOX.matter:1548:3
2022-09-15 10:36:11 ERROR ERROR: Required attributes: EP0:Switch does not expose current position(1) attribute at /home/andrei/tmp/rootnode_fan_7N2TobIlOX.matter:1548:3
PR #22629: Size comparison from d30bdd5 to 52fefc3 Increases (13 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22629: Size comparison from 5ca254a to 053a8e6 Increases (5 builds for bl602, bl702, cc13x2_26x2, qpg)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Dismissing review: updated to latest after we got the linter in, linter now complains.
@erwinpan1 - I updated to latest code where the linter runs. The error in parsing is because of the default value on available locales - external values should not have a default (and array defaults are not clear in general ... arrays are always external). So having a default there is not something that zap considered, so idl generation also chokes and generates an invalid IDL. |
PR #22629: Size comparison from 9989fc1 to 6735cec Increases (4 builds for bl602, bl702, cc13x2_26x2, telink)
Decreases (1 build for cc13x2_26x2)
Full report (34 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
* The `SupportedLocales` which has `en-US` as default value is invalid because it is Array type. * `DefaultOtaProviders` containing default value 0 is also cleared * Regenerate *.matter file from modified ZAP file
Got it. I've removed 2 invalid array default values and committed. |
PR #22629: Size comparison from 9989fc1 to 1deb779 Increases (6 builds for bl602, bl702, cc13x2_26x2, telink)
Decreases (2 builds for bl702, cc13x2_26x2)
Full report (23 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
ERROR: Required attributes: EP0:AccessControl does not expose SubjectsPerAccessControlEntry(2) attribute at ./examples/chef/devices/rootnode_fan_7N2TobIlOX.matter:1343:3 ERROR: Required attributes: EP0:AccessControl does not expose TargetsPerAccessControlEntry(3) attribute at ./examples/chef/devices/rootnode_fan_7N2TobIlOX.matter:1343:3 ERROR: Required attributes: EP0:AccessControl does not expose AccessControlEntriesPerFabric(4) attribute at ./examples/chef/devices/rootnode_fan_7N2TobIlOX.matter:1343:3 ERROR: Required attributes: EP0:Basic does not expose CapabilityMinima(19) attribute at ./examples/chef/devices/rootnode_fan_7N2TobIlOX.matter:1351:3 ERROR: Required attributes: EP0:LocalizationConfiguration does not expose ActiveLocale(0) attribute at ./examples/chef/devices/rootnode_fan_7N2TobIlOX.matter:1384:3 ERROR: Required attributes: EP0:GeneralCommissioning does not expose SupportsConcurrentConnection(4) attribute at ./examples/chef/devices/rootnode_fan_7N2TobIlOX.matter:1398:3 ERROR: Required attributes: EP0:Switch does not expose number of positions(0) attribute at ./examples/chef/devices/rootnode_fan_7N2TobIlOX.matter:1548:3 ERROR: Required attributes: EP0:Switch does not expose current position(1) attribute at ./examples/chef/devices/rootnode_fan_7N2TobIlOX.matter:1548:3
PR #22629: Size comparison from 9989fc1 to 0c22a0a Increases (7 builds for cc13x2_26x2, psoc6, telink)
Decreases (7 builds for bl602, cc13x2_26x2, cyw30739, esp32, psoc6, qpg)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22629: Size comparison from d668dc2 to ead75b9 Increases (6 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6)
Decreases (7 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22629: Size comparison from 989ad8e to 0db043f Increases (9 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, cyw30739, efr32, esp32, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22629: Size comparison from 0cf7694 to adfc39a Increases (4 builds for cc13x2_26x2, esp32, nrfconnect, psoc6)
Decreases (4 builds for bl602, cc13x2_26x2, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22629: Size comparison from 7a06f13 to 11c9a86 Increases (3 builds for esp32, nrfconnect, psoc6)
Decreases (5 builds for bl602, bl702, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Add Chef rootnode_fan as sample device
including .zap / .matter / zzz-generated files
Issue Being Resolved
Change overview
Add sample device .zap / .matter / zzz-generated callbacks