Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

[WIP] Istio: Adding Traffic Management tests #1334

Open
wants to merge 2,110 commits into
base: master
Choose a base branch
from
Open

[WIP] Istio: Adding Traffic Management tests #1334

wants to merge 2,110 commits into from

Conversation

mmnelemane
Copy link
Contributor

Why is this PR needed?

Does it fix an issue? addresses a business case?

add a description and link to the issue if one exists.

Fixes #

Reminder: Add the "fixes bsc#XXXX" to the title of the commit so that it will
appear in the changelog.

What does this PR do?

please include a brief "management" technical overview (details are in the code)

Anything else a reviewer needs to know?

Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.

Info for QA

This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug.
If this is a new feature, a good description in "What does this PR do" may be enough.

Related info

Info that can be relevant for QA:

  • link to other PRs that should be merged together
  • link to packages that should be released together
  • upstream issues

Status BEFORE applying the patch

How can we reproduce the issue? How can we see this issue? Please provide the steps and the prove
this issue is not fixed.

Status AFTER applying the patch

How can we validate this issue is fixed? Please provide the steps and the prove this issue is fixed.

Docs

If docs need to be updated, please add a link to a PR to https://github.com/SUSE/doc-caasp.
At the time of creating the issue, this PR can be work in progress (set its title to [WIP]),
but the documentation needs to be finalized before the PR can be merged.

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

JanZerebecki and others added 30 commits May 22, 2020 14:23
@JanZerebecki
make one different TERRAFORM_STACK_NAME the same
743a2e3 
Otherwise it might cut the build number off, which is what ensures it
being uniqe.

Also make the README match.
Merge pull request SUSE#1116 from pablochacin/set-ci-labels-from-pr
9fe1296 
Set CI labels from PR labels
@JanZerebecki
change ssh_sock to use TERRAFORM_STACK_NAME
5473e85 
This ensure the resulting PATH is a maximum of 1+3+1+70+1+10=86 bytes long.
When ssh-agend -a NAME is called with a NAME that is too long it fails
with:
unix_listener: path "/home/jenkins/workspace/caasp-jobs/v4/e2e/vmware/⌦
test_upgrade_plan_from_previous_with_upgraded_control_plane-daily/⌦
agent.sock" too long for Unix domain socket

Fixes: SUSE/avant-garde#1596
@davidcassany
Merge pull request SUSE#1118 from JanZerebecki/fix-ssh-sock
4072c07 
change ssh_sock to use TERRAFORM_STACK_NAME
Reorganize jobs per caasp version
5da73ae 
Reorganize jobs adding the version as a parameter
to give room for future v5 jobs.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
Merge pull request SUSE#1120 from pablochacin/organize-jobs-by-version
da18f4a 
CI: Reorganize jobs per caasp version
Set platform from pr label (SUSE#1117)
a5df22e 
Set platform from PR labels

* If PR specifies a ci-platform label, override the default test platform.
* PR tests can run in any supported platoform. Add the configuration required by libvirt to the environment.
CI: Fix name of conformace test job (SUSE#1123)
261534c 
After job reorganization introduced in da18f4a the name of
the conformance test is not the one expected, as the 'conformace'
postfix should had been removed.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
CI: Use workers with experimental settings (SUSE#1125)
3d6344a 
Some PR require experimental features that require workers
with configurations that may conflict with regular workers.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
fix suggestion for vspshere configuration (#1618) (SUSE#1131)
2079e52 
fix suggestion for vspshere configuration (#1618)

Signed-off-by: cclhsu <clark.hsu@suse.com>
Refactor all pr validation code into the pr-test pipeline (SUSE#1126)
0701ccd 
* Refactor code-lint logic

Include the code-lint logic into the pr-test pipeline to unify the
processing of all tests into one pipeline.

* CI: Remove redundant PR jobs

Once the author validation and code lint logic has been refactored into
the pr-test job, the corresponding jobs and jenkins pipelines are
redundant.
@manuelbuil
Stop using password to ssh into VMs
976cb10 
Unlike other Terraform providers, we are using the user/password
authentication in libvirt. This is not needed as the cloud-init step
will eventually configure the keys correctly and Terraform will be able
to ssh into the VM. Besides, it avoids a problem we are seeing between
ssh-agent and terraform:

hashicorp/terraform#23662

Signed-off-by: Manuel Buil <mbuil@suse.com>
Select workers for daily jobs based on version (SUSE#1129)
7ea4cd0 
Run daily jobs for multiple versions, each with a different
source branch. Also select the worker type based on the branch.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
Fix quotes in label to allow variable substitution
7e0e1a3 
Use double quotes in worker label to allow for variable
substitution.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
@JanZerebecki
Merge pull request SUSE#1135 from pablochacin/fix-label-variable-subs…
5c72f67 
…titution

Fix quotes in label to allow variable substitution
Update k8s libraries
5fcf6d0 
Signed-off-by: Vicente Zepeda Mas <vzepedamas@suse.com>
Update certificates configuration ussage
de56e32 
Signed-off-by: Vicente Zepeda Mas <vzepedamas@suse.com>
Add context ussage to all client calls
8346223 
Signed-off-by: Vicente Zepeda Mas <vzepedamas@suse.com>
refactor config defaulting for kubeadmn 1.18
8f7d820
deletes config test, obsolete
3960d69 
Signed-off-by: Vicente Zepeda Mas <vzepedamas@suse.com>
validate error on function VerifyUnmarshalStrictC
d5ab203 
Signed-off-by: Vicente Zepeda Mas <vzepedamas@suse.com>
@cmurphy
Require go version 1.13
afa4139 
Kubernetes 1.17 requires go version 1.13[1]. This change updates the
makefile version check and the package spec file template to require go
1.13 and updates the module list with `go mod tidy`. This change will
require an update to the Jenkins workers to use 1.13.

[1] https://kubernetes.io/docs/setup/release/notes/#dependencies
@thehejik
AutoYaST adapted for CaaSP 5 based on SLE-15-SP2
e5f4461
Use Repository branch from ci-repo label (SUSE#1134)
8b55cf1 
If ci-repo label is specified, set the BRANCH_REPO environment
variable to add this repo branch to the cluster nodes.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
Create separated projects for v4 and v5 jobs (SUSE#1136)
33988a9 
Separate jobs in different projects depending on the version
of CaaSP to facilitate adapting their configuration independently.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
Select worker type based on target branch for PR
4488172 
Following the convention that master and feature branches
will use the default integration worker type, while the
experimental-feature and maintenance-version branches will use
the corresponding worker types.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
Switch daily job version branches
8bd9a4a 
Make v4 run from maintenance-caasp-v4 and v5 from master

Signed-off-by: Pablo Chacin <pchacin@suse.com>
@davidcassany
Adapting terraform vars file for SLE15-SP2
3dc9fbc
@JanZerebecki
Merge pull request SUSE#1130 from pablochacin/select-worker-for-targe…
28710b4 
…t-brach

Select worker type based on target branch for PR
@dirkmueller
Switch to v5 CR container images
e7a6079 
We'd like to test the v5 versions of the k8s images.
jordimassaguerpla and others added 15 commits August 3, 2020 12:18
@jordimassaguerpla
fix gangway revision (bsc#1173165)
d05fdd1 
gangway image version was increased to 5 at this commit

SUSE/caasp-container-images@0f9800c#diff-45f24944e51aad4524696dae7dc47b2e

in order to fix bsc#1173165

Note this should be also backported to maintenance-caaspv4

Signed-off-by: Jordi Massaguer Pla <jmassaguerpla@suse.de>
Merge PR into targe Branch before building
3eab1a2 
Use checkout step for checking out and automatically merging the
pr into the target branch.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
@saschagrunert
Drain nodes before kubadm upgrade and uncordon afterwards
7ca6606 
This implements a basic drain and uncordon before/after running `kubeadm
upgrade`. To achieve that we also have to add a new helper function
`kubernetes.UncordonNode()`.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@jordimassaguerpla
Merge pull request SUSE#1285 from pablochacin/merge-pr-before-build
b7aff74 
Merge PR into target Branch before building
Merge pull request SUSE#1277 from saschagrunert/drain-uncordon
7a8854a 
Drain nodes before kubadm upgrade and uncordon afterwards
@jordimassaguerpla
Merge pull request SUSE#1296 from jordimassaguerpla/fix_gangway_revision
aec8d7c 
fix gangway revision (bsc#1173165)
Remove addon upgrade test from pr pipeline
c29e13e 
Remove test that is not part of the minimal functionality to be tested
for approving a PR.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
@jordimassaguerpla
Merge pull request SUSE#1299 from pablochacin/remove-addon-update-tes…
1637ade 
…t-from-pr

Remove addon upgrade test from pr pipeline
updated version to v4.5
6d1bd6e 
Updated versions to v4.5

includes packages and ci
updated to fix missed versions
0675836
@jordimassaguerpla
Merge pull request SUSE#1294 from Klaven/version-update
0dec0e2 
updated version to v4.5
@davidcassany @jordimassaguerpla
Revert k8s 1.17.9 upgrade
16f336f 
This reverts commit:
  * 5757a23
  * 48f33d6
  * 925f938

In 4.2.2 we have reverted k8s to 1.17 prior releasing. So we need to
backport this change to master as well.

Signed-off-by: Jordi Massaguer Pla <jmassaguerpla@suse.de>
@jordimassaguerpla
Merge pull request SUSE#1297 from jordimassaguerpla/revert_k8s_1_17_4
752446e 
Revert k8s 1.17.9 upgrade
@manuelbuil
Add the CA repo
4772c24 
Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil
Merge pull request SUSE#1309 from manuelbuil/suse_ca
4685f20 
Add the CA repo
@mmnelemane mmnelemane added the wip label Aug 20, 2020
@mmnelemane mmnelemane self-assigned this Aug 20, 2020
@mmnelemane mmnelemane added this to the 4.2.1 milestone Aug 20, 2020
@mmnelemane mmnelemane force-pushed the istio-test branch 2 times, most recently from 47e72cc to ca4ab6e Compare August 20, 2020 10:32
@Itxaka
Copy link
Contributor

Itxaka commented Nov 10, 2020

is this still valid @mmnelemane? has networking reviewed it @mbologna ?

It still needs an update...and it should be fast otherwise we should just close it.

@mmnelemane
Copy link
Contributor Author

@Itxaka A simplified test was included in Skuba and since there was no plan to include Istio in the CaaSP release, I stopped this expansion. I think it can be closed for now unless someone still requests for Istio on CaaSP 4.5.

@mmnelemane mmnelemane closed this Nov 10, 2020
@mmnelemane
Copy link
Contributor Author

I would let the branch stay, so that we can use it if needed in future.

@mmnelemane mmnelemane reopened this Nov 10, 2020
@Itxaka
Copy link
Contributor

Itxaka commented Nov 10, 2020

Thanks for the update @mmnelemane Closing the Pr does not remove the branch btw.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavio flavio Awaiting requested review from flavio flavio is a code owner

@innobead innobead Awaiting requested review from innobead innobead is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mmnelemane mmnelemane

Labels
wip
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.