-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-generate availability annotations for Darwin. #24071
Merged
bzbarsky-apple
merged 4 commits into
project-chip:master
from
bzbarsky-apple:darwin-availability-annotations
Dec 16, 2022
Merged
Auto-generate availability annotations for Darwin. #24071
bzbarsky-apple
merged 4 commits into
project-chip:master
from
bzbarsky-apple:darwin-availability-annotations
Dec 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ZAP failure is expected until that job is updated to include project-chip/zap#857 |
PR #24071: Size comparison from 8055d86 to 4ee6539 Increases (7 builds for bl602, cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Dec 14, 2022
d6c56d4
to
86b2266
Compare
86b2266
to
8234309
Compare
PR #24071: Size comparison from 59e15be to 8234309 Increases (9 builds for bl602, bl702, esp32, psoc6, telink)
Decreases (1 build for esp32)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
The changes to the generated code are as follows: * MTRBaseClusters.h: * Some newlines after MTR_NEWLY_AVAILABLE were removed. This led to a smaller diff than adding blank lines in all the places that do not use MTR_NEWLY_AVAILABLE. The newlines will return once we add availability annotations to everything we shipped in the initial Matter release, in a followup. * MTRLevelControlOptions gained the availability annotation it was missing. * Enum and bitmap values now have availability annotations. * MTRClusterConstants.h: * ClientMonitoring bits that should not have been generated (because it was added after we made the API changes that those bits are backwards compat shims for) were removed. * The availability annotations on MTRClusterDescriptorAttributeDeviceTypeListID got reordered (because the new autogenerated things put API_AVAILABLE before the deprecation annotation). * MTRClusters.h: * Some newlines after MTR_NEWLY_AVAILABLE were removed, similar to MTRBaseClusters.h. * Various selectors on clusters that have been newly added (e.g. due to renames) now have the right availability annotations. Most of the diff here is from the UnitTesting cluster. * Some typos in deprecation messages ("writeAtribute" instead of "writeAttribute" were fixed). * MTRCommandPayloadsObjc.h * Commands fields now have availability annotations. * MTRClientMonitoringClusterRegisterClientMonitoringParams and MTRClientMonitoringClusterStayAwakeRequestParams gained the availability annotation they were missing. * MTRStructsObjc.h * Struct fields now have availability annotations. * Deprecation annotation added to MTRDescriptorClusterDeviceType. * MTRClientMonitoringClusterMonitoringRegistration gained the availability annotation it was missing. * Fixes project-chip#23880 * Fixes project-chip#23680
* Put the availability data filename in templates.json. * Deprecation of a container should deprecate all its contents.
8234309
to
e15578e
Compare
PR #24071: Size comparison from 23f0824 to e15578e Increases (6 builds for cc13x2_26x2, esp32, nrfconnect, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, k32w, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Fast-tracking platform-specific change with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to the generated code are as follows:
MTRBaseClusters.h:
MTRClusterConstants.h:
MTRClusters.h:
MTRCommandPayloadsObjc.h
MTRStructsObjc.h
Fixes Handle new cluster additions better in Darwin codegen #23880
Fixes Add MTR_NEWLY_AVAILABLE to MTRLevelControlOptions #23680