Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove epoch authority count #3154

Merged
merged 3 commits into from
Apr 28, 2023
Merged

refactor: remove epoch authority count #3154

merged 3 commits into from
Apr 28, 2023

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Apr 28, 2023 •
edited
Loading

Checklist

Please conduct a through self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Less state to track/go out of sync now.

@kylezs kylezs requested a review from dandanlen April 28, 2023 07:59
dandanlen
dandanlen approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@dandanlen dandanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, worth checking with the product team to see if this will break anything.

@kylezs kylezs enabled auto-merge (squash) April 28, 2023 08:58
@kylezs kylezs merged commit 71c1a44 into main Apr 28, 2023
@kylezs kylezs deleted the refactor/remove-epoch-authority-count branch April 28, 2023 09:09
syan095 added a commit that referenced this pull request May 4, 2023
@syan095
Merge remote-tracking branch 'origin/main' into feature/pro-228
54bcc1c 
* origin/main:
  feat: witness XCallNative and XCallToken (#3171)
  Additional Key Handover Tests (#3165)
  refactor/chore: remove db migration from 0 to 1 (#3166)
  fix: use correct stage name for PubkeyShares0 PRO-259 (#3167)
  ci: add timeout to post-checks ⏳ (#3169)
  chore: parallel post-check and publish (#3168)
  fix: add missing features on dep in utils (#3164)
  Moved multisig to its own crate (#3147)
  Refactor/database (#3150)
  fix: correct addresses for localnets (#3162)
  refactor/scc (#3078)
  fix: remove cancel workflow (#3160)
  refactor: remove epoch authority count (#3154)
  chore: remove mentions of sui (#3158)
  fix: remove duplicate role check (#3157)
  chore: remove unused quickcheck dep (#3156)
  feat: refactor Chainflip trait (#3144)
  chore: remove unused CFE deps (#3152)

# Conflicts:
#	state-chain/pallets/cf-swapping/src/mock.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandanlen dandanlen dandanlen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylezs @dandanlen