Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove mentions of sui #3158

Merged
merged 1 commit into from
Apr 28, 2023
Merged

chore: remove mentions of sui #3158

merged 1 commit into from
Apr 28, 2023

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Apr 28, 2023

Closes: PRO-193

Checklist

Please conduct a through self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

We aren't supporting SUI at launch now, so just removing any mentions from the codebase. Leaving ed25519 in though of course.

@linear
Copy link

linear bot commented Apr 28, 2023

PRO-193 Remove mentions of SUI

We don't have a partnership with SUI so there's no current plan to support them. We can remove a few mentions of SUI we have in the codebase

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #3158 (b9eac4a) into main (4f7b651) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main    #3158   +/-   ##
=======================================
  Coverage   69.11%   69.11%           
=======================================
  Files         310      310           
  Lines       48285    48285           
  Branches    48285    48285           
=======================================
  Hits        33372    33372           
  Misses      10155    10155           
  Partials     4758     4758           
Impacted Files Coverage Δ
engine/src/multisig/crypto.rs 72.72% <0.00%> (ø)
engine/src/multisig/crypto/ed25519.rs 72.61% <ø> (ø)
engine/src/p2p/muxer.rs 88.54% <0.00%> (ø)
engine/src/multisig/crypto/tests.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kylezs kylezs merged commit 6fc727d into main Apr 28, 2023
@kylezs kylezs deleted the chore/remove-sui branch April 28, 2023 09:07
syan095 added a commit that referenced this pull request May 4, 2023
* origin/main:
  feat: witness XCallNative and XCallToken (#3171)
  Additional Key Handover Tests (#3165)
  refactor/chore: remove db migration from 0 to 1 (#3166)
  fix: use correct stage name for PubkeyShares0 PRO-259 (#3167)
  ci: add timeout to post-checks ⏳ (#3169)
  chore: parallel post-check and publish (#3168)
  fix: add missing features on dep in utils (#3164)
  Moved multisig to its own crate (#3147)
  Refactor/database (#3150)
  fix: correct addresses for localnets (#3162)
  refactor/scc (#3078)
  fix: remove cancel workflow (#3160)
  refactor: remove epoch authority count (#3154)
  chore: remove mentions of sui (#3158)
  fix: remove duplicate role check (#3157)
  chore: remove unused quickcheck dep (#3156)
  feat: refactor Chainflip trait (#3144)
  chore: remove unused CFE deps (#3152)

# Conflicts:
#	state-chain/pallets/cf-swapping/src/mock.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants