Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing features on dep in utils #3164

Merged
merged 1 commit into from
May 2, 2023
Merged

Conversation

j4m1ef0rd
Copy link
Contributor

Summary

Not sure how this one made it past the CI. A missing feature on the tracing-subscriber dep causes a build error in the utilities crate, but not all the time. I'm guessing that this is something to do with the feature flag that is it under.

@j4m1ef0rd j4m1ef0rd added the bug Something isn't working label May 2, 2023
@j4m1ef0rd j4m1ef0rd requested a review from msgmaxim May 2, 2023 04:23
@j4m1ef0rd j4m1ef0rd self-assigned this May 2, 2023
@msgmaxim msgmaxim merged commit fdca074 into main May 2, 2023
@msgmaxim msgmaxim deleted the fix/missing-dep-feature branch May 2, 2023 04:34
syan095 added a commit that referenced this pull request May 4, 2023
* origin/main:
  feat: witness XCallNative and XCallToken (#3171)
  Additional Key Handover Tests (#3165)
  refactor/chore: remove db migration from 0 to 1 (#3166)
  fix: use correct stage name for PubkeyShares0 PRO-259 (#3167)
  ci: add timeout to post-checks ⏳ (#3169)
  chore: parallel post-check and publish (#3168)
  fix: add missing features on dep in utils (#3164)
  Moved multisig to its own crate (#3147)
  Refactor/database (#3150)
  fix: correct addresses for localnets (#3162)
  refactor/scc (#3078)
  fix: remove cancel workflow (#3160)
  refactor: remove epoch authority count (#3154)
  chore: remove mentions of sui (#3158)
  fix: remove duplicate role check (#3157)
  chore: remove unused quickcheck dep (#3156)
  feat: refactor Chainflip trait (#3144)
  chore: remove unused CFE deps (#3152)

# Conflicts:
#	state-chain/pallets/cf-swapping/src/mock.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants