Additional Key Handover Tests #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3165 +/- ##
==========================================
+ Coverage 68.52% 68.54% +0.01%
==========================================
Files 314 314
Lines 48816 48858 +42
Branches 48816 48858 +42
==========================================
+ Hits 33453 33488 +35
- Misses 10603 10606 +3
- Partials 4760 4764 +4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
j4m1ef0rd
approved these changes
May 3, 2023
| // Accounts (3), (4) and (5) will receive the key as the result of this ceremony. | ||
| // (Note that (3) appears in both sets.) | ||
| let new_set: BTreeSet<_> = all_account_ids.iter().skip(2).take(3).cloned().collect(); | ||
| assert!(sharing_subset.is_subset(&original_set)); | ||
|
|
||
| // Perform a regular keygen to generate initial keys: | ||
| let (initial_key, mut key_infos) = keygen::generate_key_data::<Scheme>( | ||
| original_set.clone().into_iter().collect(), |
There was a problem hiding this comment.
Suggested change
| original_set.clone().into_iter().collect(), | |
| original_set.clone(), |
| type Scheme = BtcSigning; | ||
| type Point = <Scheme as CryptoScheme>::Point; | ||
| type Scalar = <Point as ECPoint>::Scalar; | ||
| fn to_account_id_set<T: AsRef<[u8]>>(ids: T) -> BTreeSet<AccountId> { |
There was a problem hiding this comment.
Could be worth moving this into helpers so we can use it in other places. Could make the ACCOUNT_IDS lazy_static use it.
The db tests could use it, but it will need to be outside of helpers so we can put it under the "test" feature flag. Maybe we need a "common_helpers" file.
We can do it in another PR.
There was a problem hiding this comment.
Sure, let me make another PR.
syan095
added a commit
that referenced
this pull request
May 4, 2023
* origin/main: feat: witness XCallNative and XCallToken (#3171) Additional Key Handover Tests (#3165) refactor/chore: remove db migration from 0 to 1 (#3166) fix: use correct stage name for PubkeyShares0 PRO-259 (#3167) ci: add timeout to post-checks ⏳ (#3169) chore: parallel post-check and publish (#3168) fix: add missing features on dep in utils (#3164) Moved multisig to its own crate (#3147) Refactor/database (#3150) fix: correct addresses for localnets (#3162) refactor/scc (#3078) fix: remove cancel workflow (#3160) refactor: remove epoch authority count (#3154) chore: remove mentions of sui (#3158) fix: remove duplicate role check (#3157) chore: remove unused quickcheck dep (#3156) feat: refactor Chainflip trait (#3144) chore: remove unused CFE deps (#3152) # Conflicts: # state-chain/pallets/cf-swapping/src/mock.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3041
(commit names are self-explanatory)