Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: witness XCallNative and XCallToken #3171

Merged
merged 4 commits into from
May 3, 2023
Merged

feat: witness XCallNative and XCallToken #3171

merged 4 commits into from
May 3, 2023

Conversation

msgmaxim
Copy link
Contributor

@msgmaxim msgmaxim commented May 3, 2023

Pull Request

Closes: PRO-260

Checklist

Please conduct a through self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Just adding the two calls to the Vault witnesser and calling ccm_ingress.

@msgmaxim msgmaxim requested a review from kylezs May 3, 2023 05:27
@linear
Copy link

linear bot commented May 3, 2023

PRO-260 Witness XCallToken and XCallNative

XCallNative + XCallToken should call the ccm_ingress extrinsic in the swapping pallet.

This will be done in vault.rs on the CFE.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #3171 (b80e147) into main (b710c99) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head b80e147 differs from pull request most recent head 9f868fa. Consider uploading reports for the commit 9f868fa to get more accurate results

@@            Coverage Diff             @@
##             main    #3171      +/-   ##
==========================================
- Coverage   68.44%   68.37%   -0.08%     
==========================================
  Files         314      314              
  Lines       48716    48767      +51     
  Branches    48716    48767      +51     
==========================================
- Hits        33344    33342       -2     
- Misses      10614    10667      +53     
  Partials     4758     4758              
Impacted Files Coverage Δ
engine/src/eth/vault.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@kylezs kylezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kylezs kylezs enabled auto-merge (squash) May 3, 2023 06:39
@kylezs kylezs merged commit e672922 into main May 3, 2023
@kylezs kylezs deleted the feat/witness-xcall branch May 3, 2023 07:14
syan095 added a commit that referenced this pull request May 4, 2023
* origin/main:
  feat: witness XCallNative and XCallToken (#3171)
  Additional Key Handover Tests (#3165)
  refactor/chore: remove db migration from 0 to 1 (#3166)
  fix: use correct stage name for PubkeyShares0 PRO-259 (#3167)
  ci: add timeout to post-checks ⏳ (#3169)
  chore: parallel post-check and publish (#3168)
  fix: add missing features on dep in utils (#3164)
  Moved multisig to its own crate (#3147)
  Refactor/database (#3150)
  fix: correct addresses for localnets (#3162)
  refactor/scc (#3078)
  fix: remove cancel workflow (#3160)
  refactor: remove epoch authority count (#3154)
  chore: remove mentions of sui (#3158)
  fix: remove duplicate role check (#3157)
  chore: remove unused quickcheck dep (#3156)
  feat: refactor Chainflip trait (#3144)
  chore: remove unused CFE deps (#3152)

# Conflicts:
#	state-chain/pallets/cf-swapping/src/mock.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants